Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp572710ybk; Fri, 15 May 2020 08:06:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrBstc1IYKmTnUkdmsU1j00r4clFKG56LmeLXnxX+3yPkQqiz20WXO14XTiaImhVWIvb28 X-Received: by 2002:a17:906:560b:: with SMTP id f11mr3000535ejq.264.1589555178607; Fri, 15 May 2020 08:06:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589555178; cv=none; d=google.com; s=arc-20160816; b=u1ltgDUU6H5eyHZz4+1OT5Bz3B0ihbvaB7uLzgSuoOyVX9XJCQZLQs7/gcsAHOc/Ay 66tTPwrc284djqOMDmxiYlRD90UR9Q2waHJUDDlNxbQsseQDfEO7ruS3pCsdBAzy01x1 woAOeUU6ZhM03mcT3hhCB1WrSjMAr/D3iTvVvIQ2hZDQEhI1DCO86ciSyQ+kWJqIU54K E7ZKpC5LClK7S/B2CQI8mWRyEIXHtoC7uhMqEcaFEeImvZIv40xEETYwL5gsSRJv+kPr QhyC34gs/K/01F60gtUgS4l37l+A7M6oR684Q/KVjl07I5JK2K9qmhecDL1ypuRIeawt QnSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=bOmDunhfUaahaaiKVLHLTe7nnH/k9WP55G/+iETR4Xc=; b=x/w1VFbDyWmlN0aFavmUK7Z7lesHpMZAvhn6OQcvlluaKEa2HcjdyFf07lTQY+VPOF /Ol1AUq0EpjjKanCB9MYzWoB0IsNpWQQDwVc15AbkGkil0yYGMtqLT7OIUfrDaV7Id3i ZTRiQ8u8I9lX9iZsWaZZ600JJvae64ahocchhdeBxEbH7Z3TCERojvtYU2LmvyU03uZN xOI2dG/1xl6svWFfcdm8rRPgbXiuw5Q1weNpHEzSQqYWw263A5WBfn79OA4tWDC9PEd/ pVRIcXT7OwhDE0oq10/mOe5jKwrWXn8ESSErDfhUGRUZ9Rssu5xr8PN1a1ayXW+cZueQ iQIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=H9vVXern; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm8si1268214edb.417.2020.05.15.08.05.54; Fri, 15 May 2020 08:06:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=H9vVXern; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbgEOPEH (ORCPT + 99 others); Fri, 15 May 2020 11:04:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726948AbgEOPEF (ORCPT ); Fri, 15 May 2020 11:04:05 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8DFC061A0C for ; Fri, 15 May 2020 08:04:05 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id s8so2831157ybj.9 for ; Fri, 15 May 2020 08:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=bOmDunhfUaahaaiKVLHLTe7nnH/k9WP55G/+iETR4Xc=; b=H9vVXern9rQlSCkWN6cJri4qpvTSvDQ+XyA5HZCmdoHBWyKOW9AXcUWBWjH1hT8MYf clXHX9rWsmDhpfkER35klYaEnlM71Vyddf+bQIbTE3YTPAbP+LN0EUhcERiBWFHHxv0y qjrRKkP2kgSr28zIEAmbjgegZ+AjBroIw6vQ5X9fCG0szdyV2gt8+rsEb4Qn0bStPQjh LFYXIR+OfiUE8pBcPSFafrLlpVHvslGxti0xfV0E9aYzWFZiUM2zS+sYes8pgVrOJEG9 x8+/GBoWWG2pwkonjaaxGqiA5si7/N4/seynPw6womoYOhT/lGSKtIdrc9CKPEamqoAk 8/vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=bOmDunhfUaahaaiKVLHLTe7nnH/k9WP55G/+iETR4Xc=; b=GWsnh5Ey5Lr0BXT4g6XbZjjsz+kd60EUi5l9hWHoomB3eIVsS3iEUhZ1nSqhcHb7or jZbEucdyNYiGj89LvUI/+ohj5ORZoRsPq9Nr5flrgOnf8uPWOX37eJAY9Io6BbRiIBSS 9iA+TKt+Ftj1SMUfZ8V1Y0xKQ5CAAcU5bhkf9CuAKIXP/X0FHyWZnUwbsEhDiRcCLmv1 X7xo0emZScyc55jotUvDvYcfNHQVDC8ijZ8PaYVqRomhe2WT4LSIphObCeD9CYXoPO0D YY26OyE9MlfeWjmkZgAPswSUD4V22og/XTtaw5BN2szLvpXBjzGkdo38kwc8PnRYot7G qUiQ== X-Gm-Message-State: AOAM530QQ6WjuKKLkSyXw/CGr9gpPSf1XPRzbB8ND+HNNGkvszJ+BkKy ipicyrr1AYO1qF8InwL43uJFwSeQyA== X-Received: by 2002:a25:d786:: with SMTP id o128mr5956484ybg.519.1589555044732; Fri, 15 May 2020 08:04:04 -0700 (PDT) Date: Fri, 15 May 2020 17:03:36 +0200 In-Reply-To: <20200515150338.190344-1-elver@google.com> Message-Id: <20200515150338.190344-9-elver@google.com> Mime-Version: 1.0 References: <20200515150338.190344-1-elver@google.com> X-Mailer: git-send-email 2.26.2.761.g0e0b3e54be-goog Subject: [PATCH -tip 08/10] READ_ONCE, WRITE_ONCE: Remove data_race() wrapping From: Marco Elver To: elver@google.com Cc: paulmck@kernel.org, dvyukov@google.com, glider@google.com, andreyknvl@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, will@kernel.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The volatile access no longer needs to be wrapped in data_race(), because we require compilers that emit instrumentation distinguishing volatile accesses. Signed-off-by: Marco Elver --- include/linux/compiler.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 17c98b215572..fce56402c082 100644 --- a/include/linux/compiler.h +++ b/include/linux/compiler.h @@ -229,7 +229,7 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val, #define __READ_ONCE_SCALAR(x) \ ({ \ typeof(x) *__xp = &(x); \ - __unqual_scalar_typeof(x) __x = data_race(__READ_ONCE(*__xp)); \ + __unqual_scalar_typeof(x) __x = __READ_ONCE(*__xp); \ kcsan_check_atomic_read(__xp, sizeof(*__xp)); \ smp_read_barrier_depends(); \ (typeof(x))__x; \ @@ -250,7 +250,7 @@ do { \ do { \ typeof(x) *__xp = &(x); \ kcsan_check_atomic_write(__xp, sizeof(*__xp)); \ - data_race(({ __WRITE_ONCE(*__xp, val); 0; })); \ + __WRITE_ONCE(*__xp, val); \ } while (0) #define WRITE_ONCE(x, val) \ -- 2.26.2.761.g0e0b3e54be-goog