Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: I/qRcPDftRSuDS3oZ/Yg8hkzzKz87JMkmZGRX/CRyKNK9aOiBJLrIHXEjMtIKvh7ilKQjxCYBt
 0caWAGW27FWHrET47n3/5mCkj1k00dKIfJVFzi5/Q/aRnwhxytJg7FSNzrd6iVj9C4kMkZktJ3
 oFzLG8QKXY1eGP2E0krhyvx5q3nBCOtHqBva0jGRk8LlxJqe23IGOxjOPoI/BI3eLmEspPit8K
 7cwXiTKFJltJ2R8MYABxTUHdYiyqNYNf35oPm92VuNmoUVNOqHLt0xSASMqikAAS25EM7Fp+Ed
 pI4=
References: <20200513133122.25121-1-lars.povlsen@microchip.com> <20200513133122.25121-2-lars.povlsen@microchip.com> <20200514130351.GA17797@bogus>
From:   Lars Povlsen <lars.povlsen@microchip.com>
To:     Rob Herring <robh@kernel.org>
CC:     Lars Povlsen <lars.povlsen@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <linux-arm-kernel@lists.infradead.org>,
        "SoC Team" <soc@kernel.org>, <linux-mmc@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        "Microchip Linux Driver Support" <UNGLinuxDriver@microchip.com>,
        <devicetree@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: Add Sparx5 SDHCI controller bindings
In-Reply-To: <20200514130351.GA17797@bogus>
Date:   Fri, 15 May 2020 17:50:35 +0200
Message-ID: <87zha9nqno.fsf@soft-dev15.microsemi.net>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Rob Herring writes:

> On Wed, 13 May 2020 15:31:20 +0200, Lars Povlsen wrote:
>> The Sparx5 SDHCI controller is based on the Designware controller IP.
>>
>> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
>> Signed-off-by: Lars Povlsen <lars.povlsen@microchip.com>
>> ---
>>  .../mmc/microchip,dw-sparx5-sdhci.yaml        | 57 +++++++++++++++++++
>>  1 file changed, 57 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.yaml
>>
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.example.dts:20:18: fatal error: dt-bindings/clock/microchip,sparx5.h: No such file or directory
>          #include <dt-bindings/clock/microchip,sparx5.h>
>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> scripts/Makefile.lib:312: recipe for target 'Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.example.dt.yaml' failed
> make[1]: *** [Documentation/devicetree/bindings/mmc/microchip,dw-sparx5-sdhci.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Makefile:1300: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1289290
>

Rob,

The header file is added with the "parent" SoC series for Sparx5, which
was submitted separately to the SoC list.

Should I rewrite the example to avoid using the (normal) header file, or
can you add the header file?

I have verified the YAML pass dt_binding_check with the header file.

> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.

-- 
Lars Povlsen,
Microchip