Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp649685ybk; Fri, 15 May 2020 09:58:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygmz9mx3aoobdqDGV6GBsQutTh7VaGAZYDvXgaLySzH7OOcpmsS3ZaCb2pGp9p0bMZyTnT X-Received: by 2002:a50:c016:: with SMTP id r22mr3638632edb.388.1589561902144; Fri, 15 May 2020 09:58:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589561902; cv=none; d=google.com; s=arc-20160816; b=s+TsMTVyWKjnr07hLOY8GMDr5Vx8A6/r7EeMKvaZKffeqLWOipHspTUXDaRbVZdACd ZZz4g7snZ8DzJn5/AofQjcNWuC8aYwpcuJbhICsNl/smoI6oi43Ebgd04cdoYkibZEYW 91aiT/cI1YDe3jDTZo1aKBuSXWxvV/Dq8YTcOyzl36M/gmYQQ4bged1Nh90FcRRtgaJi bMEsB69HXHEMkjkjRhC7XboloVd/WLQS5gmSyX54howrWeorxd/eZF4f8FqJTwAYPHJO q4aZXpp2iKph47zMkGmC95ZhF22raLQ3u75XBr8eJXMnDUoZbFQNWjBVMsPV/N/TLzC0 wLZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JudnTOw8qOhbtAye593VEuVBD57+Yl0lDDzKDfYcWCQ=; b=sgx1eLaEF3+GFTN1WUiesWy66ja0m2U+ULXDr+Ry9/kge4a1SyJcVpW+6bsKGdJc74 uNfe2MrkpwCtgx80/542W5OkrSk/LVqrDQ/u0qcD6+0wub5EYU89F6wM2MulAzH8yCbM yitA/D3fPZFd5vrrmGKWGSBEzuM7ZfQuuFuxy1xiXJz8oDSRa+DgiDKsL/trIVDsOVc6 eCaglXKbONl0cJYEv39AVXSbtkdW7t+S/HvbKEhq/rpm5WEuOMOrhBt9Ouy2VaqFUM+a XAzxsjZMPdWfCHLPtEUBL0xZVTfXg71mt31JGiZ4KGS2rx5tn01OGqZswSJFzoSNw7Lu SALQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si1765526edk.226.2020.05.15.09.57.59; Fri, 15 May 2020 09:58:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726248AbgEOQ4g (ORCPT + 99 others); Fri, 15 May 2020 12:56:36 -0400 Received: from elvis.franken.de ([193.175.24.41]:54429 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgEOQ4f (ORCPT ); Fri, 15 May 2020 12:56:35 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jZddK-0003Kr-00; Fri, 15 May 2020 18:56:26 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 20A7AC04A2; Fri, 15 May 2020 18:55:57 +0200 (CEST) Date: Fri, 15 May 2020 18:55:57 +0200 From: Thomas Bogendoerfer To: Tiezhu Yang Cc: jiaxun.yang@flygoat.com, Huacai Chen , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT Message-ID: <20200515165557.GA19106@alpha.franken.de> References: <1589512985-27419-1-git-send-email-yangtiezhu@loongson.cn> <1589512985-27419-2-git-send-email-yangtiezhu@loongson.cn> <20200515073938.GA8289@alpha.franken.de> <7715fe64-5d28-f8c8-3b04-0bf2b9f16497@loongson.cn> <5AA0EB3A-DF33-4BE7-804C-45F6B51A0CF7@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 04:54:09PM +0800, Tiezhu Yang wrote: > Because CONFIG_HAVE_STD_PC_SERIAL_PORT is not used anymore, > (2) Should we remove this arch/mips/kernel/8250-platform.c? lets get rid of it. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]