Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp673990ybk; Fri, 15 May 2020 10:33:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmGFrpGWuDmxmC4De0/FykLUe8hrjbM6CVsJ7OQFl4b+8ZppUeAEHy+QD1+0QG3uoGr4iB X-Received: by 2002:a17:906:6990:: with SMTP id i16mr3759028ejr.175.1589563991701; Fri, 15 May 2020 10:33:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589563991; cv=none; d=google.com; s=arc-20160816; b=li+RF0ieJtgNaCljoxnXXQY9nZDndv9iCHDXCb8IIfII87PWwgKinxD105fqFeHUh+ Sle6WfvmmmOGQqXEdU+jgbOD8zcrF41MOqIdYfvP7+6VHjyGhH6+s8bYvQu1k8i81j0k MNuL65BMkyEYzb0CL1Pryx/5+Cv/WjeOqTmE/iK6DOKeymQhXN4EM7bmVn3R8JyhULWO L6BxM8a3Qjw1zvpgwfXxngjN0OqmFdnLXbAz8i0KpDh5pa86u2pJApJOwclFl49B8GFg vLDsGo4OEmc87EU1cXWer81unh26Q3Pj3BdLg/Cgwprs1OA6RZKSPadhUooZeiiqut+7 BwYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=5MPOrQDOKqeTXwscqwuNzAb5HBpPkpen1n2ZQi8elSM=; b=TriTHW5G9ww5w53CF+Q33kEjOdLeE1/38NKnEN00E/ttlVEAba4x56DcD9s8azgZ+3 ziBtbEVtKpnxOxcWav7QCTLEESHJ9h0r4ipYO88lftTG7Jmtc46q7BAdCFmeuKCmL4kG NmhykXd9AGj3jgcJHeYAb7h9R/M4LqPAZGjfqzsPr/4Ejuet4cCDZfMysHZMaIdQUXLj 5jwMKPbU7v6jhnx9EcAyIfkYORnCMDjaE7yYMGRuGBeSFf/I07nhmBLljPhQe/9BbvK4 8xzfXNOPddPjvuBCKI/DFvEF5zpXiwhuaYLrAD/iPDsg16vSy0dmrBVbWWC4MEoz/rHM M3Fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si1025574edg.459.2020.05.15.10.32.48; Fri, 15 May 2020 10:33:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726615AbgEORbZ (ORCPT + 99 others); Fri, 15 May 2020 13:31:25 -0400 Received: from mailomta22-sa.btinternet.com ([213.120.69.28]:44947 "EHLO sa-prd-fep-046.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726168AbgEORbZ (ORCPT ); Fri, 15 May 2020 13:31:25 -0400 Received: from sa-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.38.4]) by sa-prd-fep-046.btinternet.com with ESMTP id <20200515173122.JWXS4105.sa-prd-fep-046.btinternet.com@sa-prd-rgout-001.btmx-prd.synchronoss.net>; Fri, 15 May 2020 18:31:22 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [31.53.141.224] X-OWM-Source-IP: 31.53.141.224 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduhedrleekgdduuddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufffkffosedttdertdertddtnecuhfhrohhmpeflohhhnhcuqfhlughmrghnuceojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqeenucggtffrrghtthgvrhhnpeegfedthfefueeihffgkeefteehuddttdefudetveelveefvdefhfejieejhffggfenucfkphepfedurdehfedrudeguddrvddvgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehhvghnrhihrdhhohhmvgdpihhnvghtpeefuddrheefrddugedurddvvdegpdhmrghilhhfrhhomhepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoeguvghvvghlsegurhhivhgvrhguvghvrdhoshhuohhslhdrohhrgheqpdhrtghpthhtohepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhrgheqpdhrtghpthhtohepoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqpdhrtghpthhtohepoehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry.home (31.53.141.224) by sa-prd-rgout-001.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5E3A241110DA42BA; Fri, 15 May 2020 18:31:22 +0100 From: John Oldman To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman Subject: [PATCH] staging: rtl8723bs: Using comparison to true is error prone Date: Fri, 15 May 2020 18:31:08 +0100 Message-Id: <20200515173108.14739-1-john.oldman@polehill.co.uk> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix below issue reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index 5ebf691bd743..0f95009a30b6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -756,7 +756,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) static u32 no_gkey_bc_cnt; static u32 no_gkey_mc_cnt; - if (psecuritypriv->binstallGrpkey == false) { + if (!psecuritypriv->binstallGrpkey) { res = _FAIL; if (start == 0) @@ -1837,7 +1837,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) static u32 no_gkey_bc_cnt; static u32 no_gkey_mc_cnt; - if (psecuritypriv->binstallGrpkey == false) { + if (!psecuritypriv->binstallGrpkey) { res = _FAIL; if (start == 0) @@ -2369,7 +2369,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller) struct security_priv *securitypriv = &(adapter->securitypriv); u8 status = _SUCCESS; - if (securitypriv->btkip_countermeasure == true) { + if (securitypriv->btkip_countermeasure) { unsigned long passing_ms = jiffies_to_msecs(jiffies - securitypriv->btkip_countermeasure_time); if (passing_ms > 60*1000) { DBG_871X_LEVEL(_drv_always_, "%s("ADPT_FMT") countermeasure time:%lus > 60s\n", -- 2.17.1