Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp747659ybk; Fri, 15 May 2020 12:26:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVLweiMmDC6zlL1EU3cwFu8CLigUbTRxXGIEyFMP9XkqnBnene/qGDwwfaPAiIPsy/V+Zu X-Received: by 2002:a17:906:2799:: with SMTP id j25mr4133469ejc.369.1589570814903; Fri, 15 May 2020 12:26:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589570814; cv=none; d=google.com; s=arc-20160816; b=0lQjxDa04PoYem0EpMl/y0/e0kVYieHNd0rRljB68erxrQKB3T8jxKggsIWKVNeDIH n2lp7zYV0YXaBpx7wHgnzqJBg7QiFmzznDGJjJNNIzE8U8jwD9Nmce9u9v7Hy4DH8p3m sM7M4fnkSrcFyT0pqeOpbr3lhaizVFA/8hMqAYChV9uProVCXNq0zCVkwCOVsqCM0uE2 6DeAfQ/29bO0kNHUaej6z/U0PtSoBPqdkU7y6ORP7/sEnjE8bkgdBA/ifsGUqCgMt6y+ eNuBVo5xcU4trmZiBs8lkZ77qh0gJWNaKbdmH5lB0kaFT1JqJG1QD/fgkr3Mb80k0OCJ dJOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=a36hrCvkPbUg843/bSmumOn78+ipKHZWMg5XvSohP3o=; b=IJVB+BHjDyYvGL68yh3Bq7JT40q/9gPhZcdH0VBY5d2ejPCU+DG43ak8vx/Cl0XJWC 2Zqp6iD+eKMZVy3vXCJ9Hda3cgwUxh0mmWPjhlmui419zP1upAMe71ixXasai5IdR+xe rwMK1uScKD9dmMUNrn0pwLUzOtSP0otph9NTELE0L/opd/dylRl/tJBxWgg9bSOHk8aT /2UeVo/fGtDIAsrLmtW/1qH2byVoskzEVXNYH4qnaqwNCm1QG6DZqr6Mp0A9800IJAE0 nMNqcfOdKEXMxhls8WnVQGo99f4XBKqSu0o/46yD+01kZaXlSTtIxjKj0qP8GCAtLSnu br5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@soleen.com header.s=google header.b=PY8rmKLs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp5si2564571ejc.344.2020.05.15.12.26.32; Fri, 15 May 2020 12:26:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@soleen.com header.s=google header.b=PY8rmKLs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726585AbgEOTYa (ORCPT + 99 others); Fri, 15 May 2020 15:24:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726227AbgEOTYa (ORCPT ); Fri, 15 May 2020 15:24:30 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC40C05BD09 for ; Fri, 15 May 2020 12:24:29 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id x1so3150019ejd.8 for ; Fri, 15 May 2020 12:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=a36hrCvkPbUg843/bSmumOn78+ipKHZWMg5XvSohP3o=; b=PY8rmKLsoOIAWMnudxgpiJvpNf1j1UsqVeSDR8qlbXb2PjKGGE3Wy9ytx1c5odlDP2 Y7jk9kBiWi7s1ZLcWH8gNy4I4cxa944o1z8d63G/2gVgyWoKuFjsq31zCukSiMz9oVQ/ q8mhT3nJbRKKl9LI8v8k8kBSrTeWoVS362oOdyavmXQbvC38loTmUXVsni8RSKwK5Cyw D2iY8jmZ9218Wo/3qB8puStPuHYFj0i0Zknw9HkhR3zgwqCCuOP12NAqbL4BZqQX6tJu ADQT2pCL13mYBwfnUOewfIEfVDaXhfsbM/h3ASSw7rt+zEL5wAewbqddkbJ4mno36n7h pQDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a36hrCvkPbUg843/bSmumOn78+ipKHZWMg5XvSohP3o=; b=XAXE623cOxbFS119N5TYnXHmOhKEZTHndoY2Kfvni6malhy93ikvUiEUpneHdYbOf/ Ow1EV7N1D5U+nIFzt3bEym4ZaWZI9i8pVWDOxAcrD/PRGZ1OF+DPghvy7v7b3yu12z0O htzoBXSrmtzEj4vif2RKhGyXH1jXcdPZoCEPWeFC5wHAI3QOmajwq3Y4ZzCeAXQHxs74 d2iZVFX305/AXYkOwbYhwp9mwNZKvZhTZFHEs+pyfoURyH2Nm+jfC4LRMWmQjSCwsgnN n88aIpweE6P5ZTiBKbo+OcWGeGLudyxRnKsPQ2kK0464UQQM+hF0Vq1UkBTqhog/qCrd zs/g== X-Gm-Message-State: AOAM531qYRhZjRi4/iXq16JPl/5pFk6VUNawA2kpNL8B8YqJ420FBSP7 UD6K3cZIw1tiBCI4T90/IcBQaAzv8wsCEiYh6v0Iuw== X-Received: by 2002:a17:906:aed2:: with SMTP id me18mr4576716ejb.283.1589570668270; Fri, 15 May 2020 12:24:28 -0700 (PDT) MIME-Version: 1.0 References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-4-keescook@chromium.org> In-Reply-To: <20200515184434.8470-4-keescook@chromium.org> From: Pavel Tatashin Date: Fri, 15 May 2020 15:23:52 -0400 Message-ID: Subject: Re: [PATCH v4 3/6] printk: Introduce kmsg_dump_reason_str() To: Kees Cook Cc: Petr Mladek , Sergey Senozhatsky , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Benson Leung , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Enric Balletbo i Serra , Steven Rostedt , Linux Doc Mailing List , LKML , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 2:44 PM Kees Cook wrote: > > The pstore subsystem already had a private version of this function. > With the coming addition of the pstore/zone driver, this needs to be > shared. As it really should live with printk, move it there instead. > > Link: https://lore.kernel.org/lkml/20200510202436.63222-8-keescook@chromium.org/ > Acked-by: Petr Mladek > Acked-by: Sergey Senozhatsky > Signed-off-by: Kees Cook Reviewed-by: Pavel Tatashin