Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200515165007.217120-1-irogers@google.com> <20200515165007.217120-4-irogers@google.com>
In-Reply-To: <20200515165007.217120-4-irogers@google.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 15 May 2020 12:40:31 -0700
Message-ID: <CAEf4BzbASksH9Ne7GVcdMSZRB_7nVwsr1Y4V66PfiCiK-fzQvg@mail.gmail.com>
Subject: Re: [PATCH v2 3/7] libbpf hashmap: Fix signedness warnings
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        Andrii Nakryiko <andriin@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Kajol Jain <kjain@linux.ibm.com>,
        Andi Kleen <ak@linux.intel.com>,
        John Garry <john.garry@huawei.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Leo Yan <leo.yan@linaro.org>,
        open list <linux-kernel@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 15, 2020 at 9:51 AM Ian Rogers <irogers@google.com> wrote:
>
> Fixes the following warnings:
>
> hashmap.c: In function =E2=80=98hashmap__clear=E2=80=99:
> hashmap.h:150:20: error: comparison of integer expressions of different s=
ignedness: =E2=80=98int=E2=80=99 and =E2=80=98size_t=E2=80=99 {aka =E2=80=
=98long unsigned int=E2=80=99} [-Werror=3Dsign-compare]
>   150 |  for (bkt =3D 0; bkt < map->cap; bkt++)        \
>
> hashmap.c: In function =E2=80=98hashmap_grow=E2=80=99:
> hashmap.h:150:20: error: comparison of integer expressions of different s=
ignedness: =E2=80=98int=E2=80=99 and =E2=80=98size_t=E2=80=99 {aka =E2=80=
=98long unsigned int=E2=80=99} [-Werror=3Dsign-compare]
>   150 |  for (bkt =3D 0; bkt < map->cap; bkt++)        \
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---

Acked-by: Andrii Nakryiko <andriin@fb.com>

>  tools/lib/bpf/hashmap.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/lib/bpf/hashmap.c b/tools/lib/bpf/hashmap.c
> index cffb96202e0d..a405dad068f5 100644
> --- a/tools/lib/bpf/hashmap.c
> +++ b/tools/lib/bpf/hashmap.c
> @@ -60,7 +60,7 @@ struct hashmap *hashmap__new(hashmap_hash_fn hash_fn,
>  void hashmap__clear(struct hashmap *map)
>  {
>         struct hashmap_entry *cur, *tmp;
> -       int bkt;
> +       size_t bkt;
>
>         hashmap__for_each_entry_safe(map, cur, tmp, bkt) {
>                 free(cur);
> @@ -100,8 +100,7 @@ static int hashmap_grow(struct hashmap *map)
>         struct hashmap_entry **new_buckets;
>         struct hashmap_entry *cur, *tmp;
>         size_t new_cap_bits, new_cap;
> -       size_t h;
> -       int bkt;
> +       size_t h, bkt;
>
>         new_cap_bits =3D map->cap_bits + 1;
>         if (new_cap_bits < HASHMAP_MIN_CAP_BITS)
> --
> 2.26.2.761.g0e0b3e54be-goog
>