Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp764500ybk; Fri, 15 May 2020 12:56:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztzEMdYPv8ggNcRQsc+Za2vqlkVUKHcjqSUh/ubN8V8FYeh38cZ+tiymXcEvX4tmoZJbae X-Received: by 2002:aa7:c453:: with SMTP id n19mr4440044edr.218.1589572562631; Fri, 15 May 2020 12:56:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589572562; cv=none; d=google.com; s=arc-20160816; b=fZCbrPdnEOfVfRLyovkfpH8lY+IExwh3/26fiWqhq2jB89Mm0J2aRVVbrCWaic4NWl 5fZNTBs+AC2S7PoxL0MDutAGho22+3xUPWgEV7puTfRZOoQB6/UcFuNPPJsVb4CbIhM7 6eGVaRqnVMEWbIfJ/JZWYL8cE49qvf6iKB7VmTjYcrrJZOBq01KS3IszwmVp08b3g2Qo 61LXxXA8HVykfdFsOr4ogMJhnk/y9Do7ecmdQVXKL7XPgdm+P+KjlOKrOiZB2Bc35PAt bjFjTd9YxlpzVdhSzuzjmxoQ7//hesNqQ4/MUX+ImrHevZXdtNYPld6SbRZpp7y9Alek KS4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=CImfPyQuRU9J6qU94iRi6JflxSCqW6Xck/teW2M9dQYzIeQFUQ6ExETt0GrYmLx6/R L7jyXX4m9hi4AyNIfCXbvRsqwo2XfZc3+QHBJGOI8GVg/9OSQsqmkE6eg3YPd9EPKBbV y1ILvdtpyOhZW7t94O/byodvx2ZCudOO3Y3uUNzZRnq2AYcAn5ql5nnV+LK2lCsSi33T UOFN1XzjW5xWKLzBuLQL5jPkREKsXKTs8hKoa8n5BQqUFHY15Inw+htevmY61XiUitNY ZtdrlWEesFeoAWVDyBmcQraA6rsRhI+o4EO+7kYW1xcGm17XDcsPZ/YhmH5SZGBHasQ9 G0Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WOdBZxkO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si1935924ejb.192.2020.05.15.12.55.39; Fri, 15 May 2020 12:56:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WOdBZxkO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726646AbgEOTxx (ORCPT + 99 others); Fri, 15 May 2020 15:53:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726226AbgEOTxx (ORCPT ); Fri, 15 May 2020 15:53:53 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E31DC061A0C for ; Fri, 15 May 2020 12:53:52 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id b8so1477180pgi.11 for ; Fri, 15 May 2020 12:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=WOdBZxkO9ZlChGU9oTzTvFnzf5mUvWnxclG7T4JezJMXnEFbeWIBYnzv0c5jwu2xR9 Ua3N7q+nFby1Wl8Ij1gOb/0WxV2Lt/MvTh2s4lrob2lxAcR9KO41fQ13sdSZlN1Y3XVh OTL4s6x9aG0YSd9i9ndrZNnBrE8K6mg0Mxnms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5qtf7blhXztbp1/La11Bf9xlOpWMwbs2y8ergkt/b1Y=; b=ZZSeaerUe91UmH6vK1PEhZZD68yHV+NEvqMVYmI68hCL1ErCO9R6l+K8NX10QnkS+V FjZyC0yo7/9XK2fCu22xq1RFZgr8KAv+0cU8WOUN/riDDjlPuWi4fUP/wTujkNznQo67 /gkLEfA+bQZhuzPhjLoxdcCZChDG0h0mhLmnmDH1CcaYOe3lnMfqihdS+6nuCsSCUpGu reC2i5ufwePG5+8eObbCAk+vM+zz+qDXeVfNsC4i0n5LRCe5DFV6nxbjBNFlGzQIdhKG Rm8LKd605JEsrUS/9fuDur4z5KD/Kg80hr4xxkwOSADUxnEoAOiyLPIAabp9tV0ukLeG gIjw== X-Gm-Message-State: AOAM533zJpCZCkQ+GHQpMYfBOZozKCo7NFK2q+BgNrC1A6wQFmZ6r12H Lw8owvX0fEXJ+nPGyJ4bn8tYYQ== X-Received: by 2002:aa7:9a4c:: with SMTP id x12mr5517509pfj.263.1589572432046; Fri, 15 May 2020 12:53:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h13sm2560838pfk.86.2020.05.15.12.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 12:53:51 -0700 (PDT) Date: Fri, 15 May 2020 12:53:50 -0700 From: Kees Cook To: Pavel Tatashin Cc: Petr Mladek , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Benson Leung , Rob Herring , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Enric Balletbo i Serra , Sergey Senozhatsky , Steven Rostedt , Linux Doc Mailing List , LKML , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 5/6] pstore/ram: Introduce max_reason and convert dump_oops Message-ID: <202005151253.AF4AC00@keescook> References: <20200515184434.8470-1-keescook@chromium.org> <20200515184434.8470-6-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 03:40:14PM -0400, Pavel Tatashin wrote: > pdata.dump_oops = dump_oops; > > + /* If "max_reason" is set, its value has priority over "dump_oops". */ > > + if (ramoops_max_reason != -1) > > + pdata.max_reason = ramoops_max_reason; > > (ramoops_max_reason >= 0) might make more sense here, we do not want > negative max_reason even if it was provided by the user. Yeah, that's a good point. I'll tweak that. Thanks! -- Kees Cook