Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp816254ybk; Fri, 15 May 2020 14:31:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEOd2gDAjnSHicQ7UZBsdtNT+723aNv/11CAm3dbtaXfAR/yxDyl2uxQZkMBNv5shD3L5z X-Received: by 2002:a50:f09a:: with SMTP id v26mr4801875edl.343.1589578260840; Fri, 15 May 2020 14:31:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589578260; cv=none; d=google.com; s=arc-20160816; b=Xn7IQHeDhy/5tbE27BfgsWx5e+Zk+t5dcrKq5UYDO763TS5AJrWhgapV+2SsR/te2G YTpTWk4mCTj4MvetOh2bIZeq8cMLwoa4SyIU7Wd6LEbKGavalaqQnujKb4CTCpMniSHt sukhypKkAfrPdqT+BnxzvGXt+4G/ANhDTaGmFpRgrIsgch/v5PLSJH1tB/QyrM5UBmRf BcOx12SFJatBZgvynp+G+DZA4c/wjUkQQxiuUY2b1Tvpm8rcvP2313Xs9oTgQjcDrzGj 8JOQhcIva5hd5BOZYo9qZz6hXs87ma5sjATB5PbMnCZikoQeqW0RJobUHEHg7L46Q6su vT5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BVI90Jx0mfg2mzobQ93FBFZYLfrAY+kFFbLRK534ymo=; b=RTts6Xq4ILg0LP/s55uMNjTemoIyDmipELxhzEu5JbnbtqMOkH2ZzpddesA4Iwg4Ql U7hHwUmZgQgzfNTYSZjJ4VpnFOeOOUL17b/ZZagWpYwKZRVg1MWxUQZ8KmelsmIl5pGn jF6S7Qzrl64FBIOQsKzV9gl1Rt73mRVTNni/eR6L52Y1hhYGvti4vazEp+3KGP+5Z3gj KSUMSqVMIK5Vmy2toCxsQfCO/OGV0XcG7EDMQkQzfyeZ4lcCIcWXnvHns2PiMcib/qaX /bjFoCa0g415wfUtreOYKrsKR4QloMBqHxSe5EoLwj0E0UIBvCwL2r2s9GxMZq/hLCjQ SXGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i33si1762880edc.519.2020.05.15.14.30.37; Fri, 15 May 2020 14:31:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbgEOV3J (ORCPT + 99 others); Fri, 15 May 2020 17:29:09 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:53441 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727867AbgEOV3C (ORCPT ); Fri, 15 May 2020 17:29:02 -0400 Received: by mail-pj1-f65.google.com with SMTP id hi11so1478894pjb.3; Fri, 15 May 2020 14:29:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BVI90Jx0mfg2mzobQ93FBFZYLfrAY+kFFbLRK534ymo=; b=ar/M2cEv/VBx2QHo3CeSYjVh1shWk97jwOG9PNwmNumzRX7dxVUdwip7nwQ+6fEeW0 BY1mLcn5ZJdqNQILAyLVBrSiQH9p7zasqRksdYiXcsLwfOycIQvvZmWK9F09bYcIWB3K gb1lXEFzb+KjodAL7UIHM+mw/lvgyfBajiWusT5NMy294dxDxOtQmQz60x+oPGOYBl9G BZzFexzQ5Gi27DOJkREVjqfIMjaYAGmO7OCHLLAOh9p6BacgZxkhWLJyOPbvAsiGMBj6 lcR2cfZ8AOf0du9cdtSOyAaPY+k7+p2PmeXwY/jQs7bpUN7waAgxnKaYk3h9sHbAaVZQ Vjuw== X-Gm-Message-State: AOAM531RbIPEYAJuOewWibkXYYUjXICt1H/23gIcJvH9I4Sw9qLCa7sj EVqFkC9cG7Ws6b6UWWZBxq8= X-Received: by 2002:a17:90a:bf08:: with SMTP id c8mr5687943pjs.13.1589578140564; Fri, 15 May 2020 14:29:00 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id kr1sm2174731pjb.26.2020.05.15.14.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id ED1424230A; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Douglas Miller Subject: [PATCH v2 08/15] ehea: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:39 +0000 Message-Id: <20200515212846.1347-9-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Douglas Miller Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 0273fb7a9d01..6ae35067003f 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3285,6 +3285,8 @@ static void ehea_crash_handler(void) { int i; + module_firmware_crashed(); + if (ehea_fw_handles.arr) for (i = 0; i < ehea_fw_handles.num_entries; i++) ehea_h_free_resource(ehea_fw_handles.arr[i].adh, -- 2.26.2