Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp859616ybk; Fri, 15 May 2020 15:55:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV3rHcouIAkKH2CfHsVNDa0yORgwUxrhJiM2PSsqUF1Gxr6H8crlpkZqL7hzgvL9I1l3W3 X-Received: by 2002:a17:906:f91:: with SMTP id q17mr5114413ejj.7.1589583346392; Fri, 15 May 2020 15:55:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589583346; cv=none; d=google.com; s=arc-20160816; b=Romo6+pPsn+EVDnsbqmk8MDWQh0FfSRAv/Zn7WsZDDVjCoXCZ58jFcwP8yrC/jOi57 FWkokidZiQ3ijTKHg/wLmvp9PrqUM16caUv1ZLbGnjfytl+hWiuS4scNdVMMdgHrujEB hbs9xS+r2RTkhfyD5gcuwIqGAl+MCxkaJgJ7tBV2l0+Bq/aASlZnyuZWPE8ajbuBPVss enhPsRrDOv9MFD9wU9/Akf3vXfSsD3QEzVIVTA/Y2uwSSF08EITnOYMVMDe3H+KJMYpC zxsolrjtEAXL+6YvCsKuvSpS0bqIfZ2mXeGJuv3Pi99Vmj38OMayxZBDWPkIgokeF5br rLGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=sjzP2nG+ZziKL9PieBtlvPa8y2mCK/O+iUD7R7SsH4k=; b=lF5ppL9uqo+Bx7VtL41MC1bNqV8mKGVq37xmOl6aJffnfJAiVjUA6JM3lWsLy5lhRk f1UXxgdmZd1wYP5nxfsHA5eF3VygGfxNJkXkR5mJ5yyUcsWti4EToj1kBdJSf590L+P/ XR7IdOSBJAj+9+1uJIV+AjZTDQN6LRHbZA7ZD1dk4e1dg+YSHBoQktdHNul+rOwBWyzm /fLJxTEj0/vRFG07npRyKuHyRV3W7oWVmwGEGNDU9zAJw0x3B/0PnDyvJPgz+x6UuZVj EfwHgvWxNWSDcEh0a2WQd01w/tkvg5KWDS2X65M5KUh8hyH1WhiqFmpO+vj4cPngeNdx nWTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j4si2296749ejn.341.2020.05.15.15.55.22; Fri, 15 May 2020 15:55:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbgEOWxq (ORCPT + 99 others); Fri, 15 May 2020 18:53:46 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:8081 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgEOWxq (ORCPT ); Fri, 15 May 2020 18:53:46 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.17]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee85ebf1d70078-096e9; Sat, 16 May 2020 06:53:40 +0800 (CST) X-RM-TRANSID: 2ee85ebf1d70078-096e9 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from [192.168.0.101] (unknown[112.1.172.85]) by rmsmtp-syy-appsvr09-12009 (RichMail) with SMTP id 2ee95ebf1d73562-078b7; Sat, 16 May 2020 06:53:40 +0800 (CST) X-RM-TRANSID: 2ee95ebf1d73562-078b7 Subject: Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code To: Saeed Mahameed , "davem@davemloft.net" Cc: "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "leon@kernel.org" , "linux-kernel@vger.kernel.org" References: <20200507115010.10380-1-tangbin@cmss.chinamobile.com> <20200507.131834.1517984934609648952.davem@davemloft.net> <295e31680acd83c4f66b9f928f1cab7e77e97529.camel@mellanox.com> From: Tang Bin Message-ID: Date: Sat, 16 May 2020 06:54:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <295e31680acd83c4f66b9f928f1cab7e77e97529.camel@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saeed: On 2020/5/16 6:28, Saeed Mahameed wrote: > On Wed, 2020-05-13 at 17:48 +0800, Tang Bin wrote: >> Hi David: >> >> On 2020/5/8 4:18, David Miller wrote: >>> From: Tang Bin >>> Date: Thu, 7 May 2020 19:50:10 +0800 >>> >>>> Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > ^^^^^^^ typo Sorry for this mistake, sorry. >>>> to simplify code, avoid redundant judgements. >>>> >>>> Signed-off-by: Zhang Shengju >>>> Signed-off-by: Tang Bin >>> Saeed, please pick this up. >> Does this mean the patch has been received and I just have to wait? >> > no, mlx5 patches normally go to net-next-mlx5 branch and usually > pulled into net-next once a week when i send my pull requests. > > i will reply with "applied" when i apply this patch, > but for now please fix the typo. Got it, I will send v2 for you. Thanks, Tang Bin