Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166AbWCNJkN (ORCPT ); Tue, 14 Mar 2006 04:40:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752047AbWCNJkM (ORCPT ); Tue, 14 Mar 2006 04:40:12 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:49639 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1750765AbWCNJkK (ORCPT ); Tue, 14 Mar 2006 04:40:10 -0500 Subject: Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver From: Arjan van de Ven To: Jeff Garzik Cc: Ed Lin , Andrew Morton , "linux-scsi@vger.kernel.org" , "promise_linux@promise.com" , "linux-kernel@vger.kernel.org" In-Reply-To: <44168C86.8060107@garzik.org> References: <1142327906.3027.24.camel@laptopd505.fenrus.org> <44168C86.8060107@garzik.org> Content-Type: text/plain Date: Tue, 14 Mar 2006 10:40:03 +0100 Message-Id: <1142329204.3027.26.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 29 On Tue, 2006-03-14 at 04:27 -0500, Jeff Garzik wrote: > Arjan van de Ven wrote: > >>>>+struct st_sgitem { > >>>>+struct st_sgtable { > >>>>+struct handshake_frame { > >>>>+struct req_msg { > >>>>+struct status_msg { > >>> > >>>Has this all been tested on big-endian hardware? > >>> > >> > >>No. It was only tested on i386 and x86-64 machines. > > > > > > you'll want those to be __attribute__((packed)) as well btw > > I thought that was unnecessary if the struct members are ordered such > that compiler would not add padding? the rules for when padding gets added are different for each platform though; worst case of adding it is that it serves as documentation that the layout matters :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/