Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 16 May 2020 15:16:36 +0800
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>
CC:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: Loongson: Add support for serial console
User-Agent: K-9 Mail for Android
Reply-to: jiaxun.yang@flygoat.com
In-Reply-To: <1589612588-29196-1-git-send-email-yangtiezhu@loongson.cn>
References: <1589612588-29196-1-git-send-email-yangtiezhu@loongson.cn>
Message-ID: <41961321-A428-42BF-ADDB-C2ACBBE25E4E@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B45=E6=9C=8816=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=883=
:03:08, Tiezhu Yang <yangtiezhu@loongson=2Ecn> =E5=86=99=E5=88=B0:
>After commit 87fcfa7b7fe6 ("MIPS: Loongson64: Add generic dts"),
>there already exists the node and property of Loongson CPU UART0
>in loongson3-package=2Edtsi:
>
>cpu_uart0: serial@1fe001e0 {
>        compatible =3D "ns16550a";
>        reg =3D <0 0x1fe001e0 0x8>;
>        clock-frequency =3D <33000000>;
>        interrupt-parent =3D <&liointc>;
>        interrupts =3D <10 IRQ_TYPE_LEVEL_HIGH>;
>        no-loopback-test;
>};
>
>In order to support for serial console on the Loongson platform,
>add CONFIG_SERIAL_OF_PLATFORM=3Dy to loongson3_defconfig=2E
>
>With this patch, we can see the following boot message:
>
>[    1=2E877745] printk: console [ttyS0] disabled
>[    1=2E881979] 1fe001e0=2Eserial: ttyS0 at MMIO 0x1fe001e0 (irq =3D 16,=
 base_baud =3D 2062500) is a 16550A
>[    1=2E890838] printk: console [ttyS0] enabled
>
>And also, we can login normally from the serial console=2E
>
>Signed-off-by: Tiezhu Yang <yangtiezhu@loongson=2Ecn>
>---
>
>Hi Jiaxun,
>
>Thank you very much for your suggestion=2E

Reviewed-by: Jiaxun Yang <jiaxun=2Eyang@flygoat=2Ecom>

Looks like we need a Kconfig clean up=2E
I'll do that after getting LS7A PCH support merged=2E

Anyway, thanks for catching this=2E

[=2E=2E=2E]
--=20
Jiaxun Yang