Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1130429ybk; Sat, 16 May 2020 01:57:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3xwrL54ZWz3m4GEnAkWWHIPXMCTLZP/oSJykJf9cfbOf21i6k0oZVeAdGsfWdL4Kff+d0 X-Received: by 2002:a17:906:7b52:: with SMTP id n18mr6750201ejo.292.1589619441134; Sat, 16 May 2020 01:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589619441; cv=none; d=google.com; s=arc-20160816; b=va1iejqH5skoi3V9dotWzkwfjE1zMc/6fUNDU3gJFaBk7fz4vv0AUeY1xUOClYhati 0Qs+lneO1zRQkmIKDEQMZhYiE7zC6LpReu0LLK7zs35/rIHuZp9rK9IwIqjEiqSMitB4 2ceIqy4erxWR5mYUvuZJfKMlIOM91EygqFOWCTU6F3cfzab8wFgCAPLorD2dEIAF0D7L y+noDL8lQ+u1Bj/Oo0twxxIS2L0WSDWJJk/uL1FW+7T/PGv/tT7pu2Zp7IHA5fg03Dwt PZgnbOjR4NJXZ1Opx7bNospKCGmPpB/6QTxS5D4N9qu7JKJuVU7hRw53le5enahq+KUi V/nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=RMU7AdYmK5AFk46pRv3VBYG+ynzM/wb1aDnzFhuaaEk=; b=eo65Ml810J2JQMDkWShKoE1BOkB4BNy1W3ffXqXuzOEJ97loskS/svCQv4Ars5ePo4 H3RZfSQhYWVG4nLNVUsnnXGcckkWkWP5SJ9goou+6e9iqM5vN1YHBp9t1a94bsh68b5p uOGtnDPfK8iHsoZWbfRkWXp1xhkZz4SMaI1Pi55lunFlFOd7kriUzFYLihRc8iMCQZmj 7S4OvU3zYN1RTKc8/00/d5eWebNz/5XiTqTA/yd13XwX6igaHjjS0eR8FETHoLwigJ4X mXV8HehrVSWrydnY9y4f+1DoPlzvE9Qfw0EW8kNLIu3dJfKaWT6jy/va49dhx90+40eF VnRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si2531479edf.402.2020.05.16.01.56.57; Sat, 16 May 2020 01:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbgEPIz3 (ORCPT + 99 others); Sat, 16 May 2020 04:55:29 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:50446 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726202AbgEPIz3 (ORCPT ); Sat, 16 May 2020 04:55:29 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 7865712EED413F44AA3F; Sat, 16 May 2020 16:55:25 +0800 (CST) Received: from use12-sp2.huawei.com (10.67.189.174) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Sat, 16 May 2020 16:55:17 +0800 From: Xiaoming Ni To: , , , , , , , , , , , , CC: , , , Subject: [PATCH v2 0/4] cleaning up the sysctls table (hung_task watchdog) Date: Sat, 16 May 2020 16:55:11 +0800 Message-ID: <1589619315-65827-1-git-send-email-nixiaoming@huawei.com> X-Mailer: git-send-email 1.8.5.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.189.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kernel/sysctl.c contains more than 190 interface files, and there are a large number of config macro controls. When modifying the sysctl interface directly in kernel/sysctl.c, conflicts are very easy to occur. E.g: https://lkml.org/lkml/2020/5/10/413. Use register_sysctl() to register the sysctl interface to avoid merge conflicts when different features modify sysctl.c at the same time. So consider cleaning up the sysctls table, details are in: https://kernelnewbies.org/KernelProjects/proc https://lkml.org/lkml/2020/5/13/990 The current patch set extracts register_sysctl_init and some sysctl_vals variables, and clears the interface of hung_task and watchdog in sysctl.c. changes in v2: 1. Adjusted the order of patches, first do public function extraction, then do feature code movement 2. Move hung_task sysctl to hung_task.c instead of adding new file 3. Extract multiple common variables instead of only neg_one, and keep the order of member values in sysctl_vals 4. Add const modification to the variable sixty in watchdog sysctl V1: https://lkml.org/lkml/2020/5/15/17 Xiaoming Ni (4): sysctl: Add register_sysctl_init() interface sysctl: Move some boundary constants form sysctl.c to sysctl_vals hung_task: Move hung_task sysctl interface to hung_task.c watchdog: move watchdog sysctl interface to watchdog.c fs/proc/proc_sysctl.c | 2 +- include/linux/sched/sysctl.h | 8 +- include/linux/sysctl.h | 13 ++- kernel/hung_task.c | 63 +++++++++++++- kernel/sysctl.c | 202 ++++++++----------------------------------- kernel/watchdog.c | 101 ++++++++++++++++++++++ 6 files changed, 210 insertions(+), 179 deletions(-) -- 1.8.5.6