Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1152188ybk; Sat, 16 May 2020 02:40:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz40cTNg/r9YbUGUY/G7l45Xu9ORCRiakjlRpzj0niNi1pzs2EvQMZG4BezFwgOjJC1J/oh X-Received: by 2002:a17:907:40c7:: with SMTP id nv7mr6481409ejb.16.1589622005518; Sat, 16 May 2020 02:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589622005; cv=none; d=google.com; s=arc-20160816; b=wz0bh6BTSW7EJ3fzeS01liG26/W43C33NuJifMmFM8owJNbzcMggL9Yc+/ps85GK9x MmvR1Hu/WIzLiahvCNXtwlPSVrCRWtSZ0TKApj1tyQLl1951pP3J/NyYImN5piRgvv5t 7uTFSq6D/PQqCFMfglZz6xM1DHnOuRWlfMECjoApvOQ0YJ7VziwKrvEuubEpBMEbgfVn eDWasQX6wV6gVUzxvr8DGkzWaWu2+dSgArUQWlsyFxmibT6+84kIYYWFY1oNhAdAR/11 USId3xDiljZPQFyF3v/amdVnOOj5EMANzhLMp0M614IP01KH0MxmOjIRxKzmr7r0JFJG oB2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=CHmw4w5JEiE5ORUUkfCSurvfpTUlqUQrUJG2AzzYQ1M=; b=JXMaXLgmNV6JoPeo6uI+gs422ccAUDUk1CAev9IGl5IQijLnMqjN2DF4argWrs4SY9 QPDm+7pEq1+iLC9cy6stfxPF+gG5O4qFAM2FQnbhW6JaseQSr0Oyr2QZ2OulytJpwdO8 stTLFNJOddt3Ws0wScaFnvvu/ijFOX2yKFocN08KODfu++d1GTT6mUJzyqIxBNVdIRWu fq/8fFHq8hXOIzjAFOB2ESgnaOOGhCE+K6V+QYpbq2D+/6jJXyG0WcQpl3/oSM1EkQdI QdIJMscBLIiuDlwgXx7amTtd7UkZVNylZjR/BnTN6DMpi4FJuOM4r0RRtyNnoWAeYib6 f2vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DppmAWrU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 27si3252578ejy.121.2020.05.16.02.39.41; Sat, 16 May 2020 02:40:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DppmAWrU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726946AbgEPJiL (ORCPT + 99 others); Sat, 16 May 2020 05:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726270AbgEPJiL (ORCPT ); Sat, 16 May 2020 05:38:11 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0737C05BD09 for ; Sat, 16 May 2020 02:38:10 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id 202so3856609lfe.5 for ; Sat, 16 May 2020 02:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CHmw4w5JEiE5ORUUkfCSurvfpTUlqUQrUJG2AzzYQ1M=; b=DppmAWrU75NFH2IFxxnS77sqE8wLtGku2N6i3Y/3yUu5EFHK08UmkR22QRrWU58Ngf Xv+MUMZH8B/hB4sYuDMMfMwg1cQJNeZRiKgsvpHUpMcY4VGutwkqpjKGpxojnAY6f+GG NnrtQ8jBin5gf1yBf+Xf2dEQArLHY5ldTEUaEMd+mRQph9Ulv6ZDyKtSzBgsVqqq2L/A kNPlX+XkUtynhKPRhgXXchXfb08k3t6eeJi3I2OoxzmM5fdwaQD24JtzVQ3SOxpXRs6F DNNvF8xlkTejQIGceaFFOCh00vrsNj+9o3aq7eD1sQmiKiwT8Fj2hGX1gVxyMCHkUJtj BBzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CHmw4w5JEiE5ORUUkfCSurvfpTUlqUQrUJG2AzzYQ1M=; b=d+OppwzKMqeWxDM3BRIgJkauRsVTD4o+Dd7hRaxACSQRIf1uK4FamCHgFbyyf54Ms2 momM4FNVjfJWcfvZ50Fve9qyZBNH1qBgiiY2YbDLa4YpxOw0EtFDY3GUR77M+1nZLr4l AoOMgZA2VmTrokSb2pJxJdw6fl+Ua+IBykaNtRXr9Ce0tDluq7T/IXYVA0aTy1qEsS1c MSm8vBhrUKSvZBcx48+9jalZzXmMyqXgEx5TKWfD5XTU3UGAagNU8UFiwIn2pM1Tb4fT G3+7t6Z66yO+yh3er5KxukUjkGJzb8Je3A5PRIawgmrJIpBDdc864frhiSvxmpim5PQ9 C6FA== X-Gm-Message-State: AOAM533vq37kLrIfAeogl9tjHfNkK7v1WXDn1gdJjL/m2apXasMNt/ml NEFe1tT/CLdUrUQs+zzUjYa+o00z24psO+I/U6XFog== X-Received: by 2002:ac2:5473:: with SMTP id e19mr789130lfn.21.1589621888936; Sat, 16 May 2020 02:38:08 -0700 (PDT) MIME-Version: 1.0 References: <20200511101828.30046-1-geert+renesas@glider.be> In-Reply-To: <20200511101828.30046-1-geert+renesas@glider.be> From: Linus Walleij Date: Sat, 16 May 2020 11:37:58 +0200 Message-ID: Subject: Re: [PATCH] gpiolib: Document that GPIO line names are not globally unique To: Geert Uytterhoeven Cc: Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2020 at 12:18 PM Geert Uytterhoeven wrote: > gpiochip_set_desc_names() no longer rejects GPIO line name collisions. > Hence GPIO line names are not guaranteed to be globally unique. > In case of multiple GPIO lines with the same name, gpio_name_to_desc() > will return the first match found. > > Update the comments for gpio_name_to_desc() and > gpiochip_set_desc_names() to match reality. > > Fixes: f881bab038c9667d ("gpio: keep the GPIO line names internal") > Signed-off-by: Geert Uytterhoeven Patch applied. Yours, Linus Walleij