Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8 2/6] ARM: tegra: Add device-tree for ASUS Google Nexus
 7
To:     =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        David Heidelberg <david@ixit.cz>,
        Peter Geis <pgwipeout@gmail.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Nicolas Chauvet <kwizart@gmail.com>,
        =?UTF-8?Q?Pedro_=c3=82ngelo?= <pangelo@void.io>,
        Matt Merhar <mattmerhar@protonmail.com>,
        Zack Pearsall <zpearsall@yahoo.com>,
        linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200514213654.12834-1-digetx@gmail.com>
 <20200514213654.12834-3-digetx@gmail.com>
 <20200515181847.GA13860@qmqm.qmqm.pl>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <cf73df1a-92ed-f509-74e8-1c847945fb14@gmail.com>
Date:   Sat, 16 May 2020 15:01:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200515181847.GA13860@qmqm.qmqm.pl>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

15.05.2020 21:18, Michał Mirosław пишет:
> On Fri, May 15, 2020 at 12:36:50AM +0300, Dmitry Osipenko wrote:
>> There are few hardware variants of NVIDIA Tegra30-based Nexus 7 device:
>>
>> 1. WiFi-only (named Grouper)
>> 2. GSM (named Tilapia)
>> 3. Using Maxim PMIC (E1565 board ID)
>> 4. Using Ti PMIC (PM269 board ID)
> 
> Hi,
> 
> I've briefly looked at the PM269 devicetree (PMIC part) and it looks very
> similar, if not the same, to what I deduced from the TF300T kernel.

Hello Michał,

Definitely there are board parts that are reused by different devices.
This is not surprising since most of the boards are designed by the same
company.

> Those devices don't look to differ much from original Cardhu tablet
> devkit, so maybe the trees can base off of that?

I don't think it's really possible in a case of Nexus 7 because in
overall the used hardware components differ a bit too much. It shouldn't
worth the effort, IMO.

> I would also guess that because of this 'ram-code', memory timings would
> be duplicated between devices. I can see small differences between
> ram-code=1 timings of Grouper and TF300T, though they look like arbiter
> tuning differences. I'll have to test if my TF300T works with Grouper's
> settings. In case they work, could you split the memory timings to another
> dtsi file?

Yes, perhaps this could be done. The memory timings on Grouper and
Tilapia are pretty much the same as well. As you noticed, there are some
tuning differences of TF300T in comparison to the Nexus 7, the same
applies to the Grouper and Tilapia variants.

> BTW, shouldn't EMC timing set match MC? I see more frequencies listed in
> MC than EMC nodes.

The MC timings are exactly the same on Grouper and Tilapia, but EMC
timings have a very minor differences, and thus, the common.dtsi misses
these differentiating EMC timings, they are defined in grouper.dtsi and
tilapia.dts.

I guess we indeed could try to select the lowest common denominator
timing and re-use it. I'll consider this change for v9, thank you very
much for the suggestion.