Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1384533ybk; Sat, 16 May 2020 09:35:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0br3l4rtWg3UpFSX4FCM5b6Vgz/Lckucm1kF/6UBsBPyVQfLwyBoGJFBSuR/ptuVLwbkg X-Received: by 2002:a17:907:10c2:: with SMTP id rv2mr7499838ejb.309.1589646945283; Sat, 16 May 2020 09:35:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589646945; cv=none; d=google.com; s=arc-20160816; b=YzIpl2Dbm1Kj2v3UF7Ny2bUjrx0IsU93yYyhZbxsFqd/kGwqzE4xYyK6GRIAuKHpk0 T2Hwa4QtAijj4lh1UJZky9PORLSTb1ghDeIUQNF6Zq4GOfRhoXH5YEPjKmP7ZlVtb3rg qNK+ZgGbbODKXwXf+RG5MXA55/fRCn0sTbVi9xbE487YGgIjb1MHeYf1mMdkA+LOPNuT Heu16BV50rmGnMPPIR8lzT2W3Fl9aKt20RS9yh0HshV9IA7k1n0u2Ky5X2+g+hzpLCBM HNTwRnmehtvjUgPnOLmrxOqDyYo3WUX1ci1YsSOrIOXXquIRINcgEPYcPAINe2pqkR5x hi6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=cFf9tfD4AWfQO0sXoLLGT+LdlHGB1dH10S0TfPpCsTw=; b=XFKdL+vR2pkwG8psEPXN41aqPOjlabSEMp03N5z98iEvp+KrRJBeFXoxRzeCRn79gs u1y0sgTAo1WSm29jUHXk2zJR9gB3cGcWFIhahb3SKhlKQk+/JBp/ehWqVlM5uMta8r3/ TZuozxuTHHupeQTkBEB7oiZkx0L/NTRfKu1pYhK31XR/QqFwflukN3llnUp8FSqye+6A 6nCcAJ9PnXaDMLEr4o8DaHnS8YqnwXY/Lf17b1yVJlj8ps48BplhsuDrvwswWA+tdznx pKUVEwG2KU9i8pxaaTJc/59KzCyPWV7ToHujD8isGRkO2GQ0GKl6xbgvEwt8FvT54a+a YQ3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si3126788eds.551.2020.05.16.09.35.21; Sat, 16 May 2020 09:35:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726257AbgEPQdn (ORCPT + 99 others); Sat, 16 May 2020 12:33:43 -0400 Received: from mailomta14-sa.btinternet.com ([213.120.69.20]:58277 "EHLO sa-prd-fep-044.btinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726237AbgEPQdn (ORCPT ); Sat, 16 May 2020 12:33:43 -0400 Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-044.btinternet.com with ESMTP id <20200516163340.OHMU4109.sa-prd-fep-044.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Sat, 16 May 2020 17:33:40 +0100 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=j.oldman998@btinternet.com X-Originating-IP: [31.53.141.224] X-OWM-Source-IP: 31.53.141.224 (GB) X-OWM-Env-Sender: j.oldman998@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduhedruddttddguddttdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvffufffkofestddtredtredttdenucfhrhhomheplfhohhhnucfqlhgumhgrnhcuoehjohhhnhdrohhlughmrghnsehpohhlvghhihhllhdrtghordhukheqnecuggftrfgrthhtvghrnhepgeeftdfhfeeuiefhgfekfeethedutddtfeduteevleevfedvfefhjeeijefhgffgnecukfhppeefuddrheefrddugedurddvvdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghlohephhgvnhhrhidrhhhomhgvpdhinhgvthepfedurdehfedrudeguddrvddvgedpmhgrihhlfhhrohhmpeeojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqedprhgtphhtthhopeeouggvvhgvlhesughrihhvvghruggvvhdrohhsuhhoshhlrdhorhhgqedprhgtphhtthhopeeoghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgqedprhgtphhtthhopeeojhhohhhnrdholhgumhgrnhesphholhgvhhhilhhlrdgtohdruhhkqedprhgtphhtthhopeeolhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgqe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from henry.home (31.53.141.224) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.340) (authenticated as j.oldman998@btinternet.com) id 5E3A290C1107B058; Sat, 16 May 2020 17:33:40 +0100 From: John Oldman To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman Subject: [PATCH] staging: rtl8192u: Using comparison to true is error prone Date: Sat, 16 May 2020 17:33:27 +0100 Message-Id: <20200516163327.9197-1-john.oldman@polehill.co.uk> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix below issue reported by checkpatch: CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: John Oldman --- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c index 0ee054d82832..63a561ab4a76 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c @@ -372,9 +372,9 @@ ieee80211_query_HTCapShortGI(struct ieee80211_device *ieee, struct cb_desc *tcb_ return; } - if ((pHTInfo->bCurBW40MHz == true) && pHTInfo->bCurShortGI40MHz) + if (pHTInfo->bCurBW40MHz && pHTInfo->bCurShortGI40MHz) tcb_desc->bUseShortGI = true; - else if ((pHTInfo->bCurBW40MHz == false) && pHTInfo->bCurShortGI20MHz) + else if (!pHTInfo->bCurBW40MHz && pHTInfo->bCurShortGI20MHz) tcb_desc->bUseShortGI = true; } -- 2.17.1