Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1430240ybk; Sat, 16 May 2020 11:05:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0VayqMXmq16CvRcFA0x7XaMj6qtppxgB0gv1z/nhJ0DbZjvf4J5rxVbs+o7VrREEfgZZK X-Received: by 2002:a17:906:509:: with SMTP id j9mr8174043eja.152.1589652339130; Sat, 16 May 2020 11:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589652339; cv=none; d=google.com; s=arc-20160816; b=QFpo/2iFEvJNiIcDgkEN2gAEJNdY79k8iEi6sxvdaBIi0oWCm6NVqVm3MoYivBlm8o yXcPvSAHmnnefXUMkuFOmKUIRiqTprXQ8BkZyPlJhVLycuF887C06q3BvNDEHkLbp4SX RGd2jayPgDoX8PYykEDKFiqSpwI118mXKV4oUsjlB/TjFb1j5tHTd+tTIU+Vr91wFVp6 4z6UPFvrgsDILG8tUZxlV8jw75g6WUg68zjerVgClnJ/fpV7NT72xGU9Py0qVeYnvOdo IeITGrLVHRhrO/slpMfKoZe7uHnCNYUmW+fuVS5H0jH7uaq955QKxIsAarAhVxXC0XOX ltuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=mOahOc8FO3zZU6811l5Nbqp5Wxxk1eaufWYGdj+S+4Y=; b=Ey7SbGkHqavyvq7TTt1Xqv1sMsME01p6fGqWB6LT7rjfweBUq/rGko8u6LII8vu7X0 XkVxwvug2yB4aFQRnMW8wqy3lEvAkvinE8hx2ZByL9/R+runNHsICvPJYV8cdvAn/IIt IVQDjLGxNofFRsuI5RGOXOpprGMhFOPzwa0OFkONy8xO3bgXTM4/DCewAL+uKh9vqyVW n3ZKa5ibP/hVL5ArQ1sPsJ915HAwxUx87ViXEQPYBS5791kATZX+5xMSlaMWP0/kQmk2 logtETMnyXlisXjB9JUTJ/7y2K4VbWwcdNufiXjuS1yCp0K62GKXt/r+O63Se1DXhJ1q ytNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c2si4001387ejb.278.2020.05.16.11.05.16; Sat, 16 May 2020 11:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726388AbgEPSD1 (ORCPT + 99 others); Sat, 16 May 2020 14:03:27 -0400 Received: from mga03.intel.com ([134.134.136.65]:62835 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbgEPSD0 (ORCPT ); Sat, 16 May 2020 14:03:26 -0400 IronPort-SDR: cCk9wouJxIMyRghWZ0SES4NvmjOat5mJET4p7SSP3JBF4+vRzABWXYsZxC8FF/p6SDKwSku+35 2gCFNRjaRaTA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2020 11:03:25 -0700 IronPort-SDR: Z31a2n/hd7Dsfm/lHEEvXOvaxGuk10Ms3iMtJKImczUNUybsYIu3iYxPX4Gy0+GrHA5GHyZiPy XiUyO5/GiE9A== X-IronPort-AV: E=Sophos;i="5.73,400,1583222400"; d="scan'208";a="465312117" Received: from rchatre-mobl.amr.corp.intel.com (HELO [10.251.21.145]) ([10.251.21.145]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2020 11:03:24 -0700 Subject: Re: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA To: Babu Moger , "tglx@linutronix.de" , "fenghua.yu@intel.com" , "bp@alien8.de" , "tony.luck@intel.com" Cc: "kuo-lang.tseng@intel.com" , "ravi.v.shankar@intel.com" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" References: <3510244af29b7443221dc926745fd0cf541576e0.1588808538.git.reinette.chatre@intel.com> From: Reinette Chatre Message-ID: <2e04ff69-d246-82dd-12b9-83a1f36fccfa@intel.com> Date: Sat, 16 May 2020 11:03:24 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 5/14/2020 12:04 PM, Babu Moger wrote: > > >> -----Original Message----- >> From: Reinette Chatre >> Sent: Wednesday, May 6, 2020 6:50 PM >> To: tglx@linutronix.de; fenghua.yu@intel.com; bp@alien8.de; >> tony.luck@intel.com >> Cc: kuo-lang.tseng@intel.com; ravi.v.shankar@intel.com; mingo@redhat.com; >> Moger, Babu ; hpa@zytor.com; x86@kernel.org; >> linux-kernel@vger.kernel.org; Reinette Chatre >> Subject: [PATCH V3 3/4] x86/resctrl: Enable per-thread MBA >> >> From: Fenghua Yu >> ... >> static int rdt_thread_throttle_mode_show(struct kernfs_open_file *of, >> struct seq_file *seq, void *v) >> { >> unsigned int throttle_mode = 0; >> >> + if (boot_cpu_has(X86_FEATURE_PER_THREAD_MBA)) { >> + seq_puts(seq, "per-thread\n"); >> + > You probably don't need an extra line here. > This area looks slightly different after moving to a resource property but unnecessary extra lines will be removed. Thank you very much Reinette