Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1511047ybk;
        Sat, 16 May 2020 13:44:29 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyunxxBMl2DTB9fbLxpCmgvAvHOTMZSlapN2Hd8O+5gonfvo17ypV2FrcaNSGyNoqONjv45
X-Received: by 2002:a17:906:6453:: with SMTP id l19mr8448380ejn.169.1589661868854;
        Sat, 16 May 2020 13:44:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1589661868; cv=none;
        d=google.com; s=arc-20160816;
        b=PedhViK7YJ4B0iMgEZ6N49hYym6OIoq26wkwUg1qsz9pmLx5zCw/sH6otuceJU5cqd
         lgGXv194ymhUYAU8wE8ANRjh5vERNXIrpcqVLGxykK3Hf5+G8YLHkKpSWZ+hFmV7B4mp
         CqPf6jXSMyO95Iyl9Oxv3BWdjd2lI5/BOEE7zR8y+j1SOEPlN2O6Lv4ttx7e297sFD0X
         YIj8T0V5AF4Kd4DjQPdh1AgBGnlz6psNeP0idZ5VMme6GuKpTF3LZGCfI6rFqMmxNLCW
         mmcyVBlEd0Br310MlDdeT5DE9+0TNxCJ6FhsGRnRQyppK4qjO04YdLoo9eXcSWJaow2p
         dvEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=9OwO59fsklKrWJHHqe/lPKvKK10sPj8gAiMx4I7/baU=;
        b=f91/ykvqkb1B3gyvpMwhQkRNwugj1wfkm3hpA+tqkEqJUTxSHbEULp9RN5Zg/dFmIh
         D47mMKRvEV8eGDoWFwqR8D0KMw/gNaA/KE1ur0A6IPA/xDZrTY1nxUVtgpNrwQ1NpN5w
         v6+aG5EkwwKq98u8W2sBhKk3RYtjrYLldk6j+3XOAWHdCdiiLpFvhqS2yvATDHih+3ys
         uQHPrSYVRZsEwzsYkcNh2vU8iPrc6jiSXPkgU1YXyoB7DMmKsQlpjN2g09uKh7ZZT9Qp
         JxWYPOhmI75b1fozobSujbjMhAm14uAk+MFGokYcYydACMn8NFt7vSYQVdHPkTBjAcKL
         5aGw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p1si2092931edx.168.2020.05.16.13.44.04;
        Sat, 16 May 2020 13:44:28 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726693AbgEPUkU (ORCPT <rfc822;busarih159@gmail.com>
        + 99 others); Sat, 16 May 2020 16:40:20 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35598 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1726460AbgEPUkU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 16 May 2020 16:40:20 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB830C061A0C;
        Sat, 16 May 2020 13:40:19 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 56B301194479F;
        Sat, 16 May 2020 13:40:19 -0700 (PDT)
Date:   Sat, 16 May 2020 13:40:18 -0700 (PDT)
Message-Id: <20200516.134018.1760282800329273820.davem@davemloft.net>
To:     shakeelb@google.com
Cc:     edumazet@google.com, willemb@google.com, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/packet: simply allocations in alloc_one_pg_vec_page
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200516021736.226222-1-shakeelb@google.com>
References: <20200516021736.226222-1-shakeelb@google.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 May 2020 13:40:19 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Shakeel Butt <shakeelb@google.com>
Date: Fri, 15 May 2020 19:17:36 -0700

> and thus there is no need to have any fallback after vzalloc.

This statement is false.

The virtual mapping allocation or the page table allocations can fail.

A fallback is therefore indeed necessary.