Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1511202ybk; Sat, 16 May 2020 13:44:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/QqiYAg4NPq8C3qKwHShdPRcq2auOGwTWUmRvsqcW31G3f13Up4hr5bHrXoyM0ObXL+eK X-Received: by 2002:a17:906:3e56:: with SMTP id t22mr8892452eji.277.1589661892885; Sat, 16 May 2020 13:44:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589661892; cv=none; d=google.com; s=arc-20160816; b=cO3k+zGi27uASd6SLwjmg3Rffwe5eM9Nt9au+e0REEmYaKf1ybMcaRfh1WfUgFamtq vlBDkFb9Y53IQkoKHT5JgQx4UX5K3Ij0MUjM4rce1B15n9wtnNVAdf5zQtWdupGlQ2vA 5kcm5aMg7MezevsnDItrtFi7QGUuFxZkKIuUZZJbMYs5XDUnW886KSBvBG06mCtIZ33T tG8lZ1JB9Ndg7uQy11iL6DYr9pkp5y7SNFwu6j7acE/S5ZQKPzkFSAfHnTLae5L/8yfN BygTFOHemO8rRfKpseA72KpEXGEichBCCsh0n//y8fDT9vKQ6q8ZESlXAz0+nUtPcxs8 VfaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=sPZbl8Ckw9YkCVYw4TLprEA/CJtNOyApZdAV3m5HwxE=; b=HvJ/WAbUJ+D/zzi3Zc5utW8bGWqG3RqPZ8KnJD72v2rqoJxrE0kd5Dua1WG0QXFSgS SOAZHC84FrxLxppnQBoBeCOpFOQmceZP4zIvNJQcfkp/z3KKB8fCnjegpkyp8byQKf9M +zLQ5ZkVWUCTZMK4i/gVmfR9Up2QEjCyEnD5nJkCp48oowCpka3TapmR5u1SSrFQTNHN QMf0JgPfqu/Jj6bY4dplWT9YnHcVX03wanM89vRK76Zcs7lOsY/7n9PQEjFy6s1bvHqG IQbuR6owg4KDgqdPxLknOln8FqB7mVioE7+xVDINCIQlp9XqhW5Em0XfedNaxtAexrmn IDRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c21si3612081ejr.277.2020.05.16.13.44.30; Sat, 16 May 2020 13:44:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgEPUnG (ORCPT + 99 others); Sat, 16 May 2020 16:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726527AbgEPUnG (ORCPT ); Sat, 16 May 2020 16:43:06 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14227C061A0C; Sat, 16 May 2020 13:43:06 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D41CD119447A7; Sat, 16 May 2020 13:43:04 -0700 (PDT) Date: Sat, 16 May 2020 13:43:04 -0700 (PDT) Message-Id: <20200516.134304.1945525064964213746.davem@davemloft.net> To: madhuparnabhowmik10@gmail.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, cai@lca.pw, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH net v2] ipv6: Fix suspicious RCU usage warning in ip6mr From: David Miller In-Reply-To: <20200516074515.13745-1-madhuparnabhowmik10@gmail.com> References: <20200516074515.13745-1-madhuparnabhowmik10@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 May 2020 13:43:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: madhuparnabhowmik10@gmail.com Date: Sat, 16 May 2020 13:15:15 +0530 > From: Madhuparna Bhowmik > > This patch fixes the following warning: > > ============================= > WARNING: suspicious RCU usage > 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted > ----------------------------- > net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!! > > ipmr_new_table() returns an existing table, but there is no table at > init. Therefore the condition: either holding rtnl or the list is empty > is used. > > Fixes: d1db275dd3f6e ("ipv6: ip6mr: support multiple tables") > Reported-by: kernel test robot > Suggested-by: Jakub Kicinski > Signed-off-by: Madhuparna Bhowmik Applied and queued up for -stable, thanks.