Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1516719ybk; Sat, 16 May 2020 13:58:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4G2usdqy+Xj4RgNamgd3V3wALLZylUzlnkVWbIQF9uEmLdW+IiUWAgb2dnkSKo4VKjc8N X-Received: by 2002:a50:f09a:: with SMTP id v26mr8084300edl.343.1589662706475; Sat, 16 May 2020 13:58:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589662706; cv=none; d=google.com; s=arc-20160816; b=z4dozFcsR2fT+eAEiYb0tO7/z17i722iErWlobvZgGc21KxhZ7wSE/ydc+wUYTXF4l VyslGtNn9f0PeKWl7x8Yba1hDzW0QK526aMPNq4jfh4sBG7mDVWSSnSyEann2azsoDFG YJJRK2zzPcvU/ip29LZyzaZIBQvEVkrAHc6jAIZ5Lg5a20yaf0HPjHjr0V2EpYREh0nJ uLm/gVJyDGMYn6LDkG/U/0w3udyqFWX5mKFmU5BpIIFnUU3O0L30S4RZsJXhBJVNJxg/ 4e8oM8V1beisa2fjs8AY0QagukIy4PpTKhZTby1lexW2KpKjy563IvZtFMWn9Vzw9IUM 8Z6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Sm9b3PMYVEAZypd/W55YVZjQrUrwKuzG2boAl6lU6LA=; b=iyRKpaMLNzR8vHdx9Olc8/eb25Yn6IP1GK66gRGBHaGoV8JF5f12requs9M86hcvGE 8256SRkTXnH/7/Fkdip24IMOzPaUP3yjhVFobee1NPX5qzXneBO8sRs8JhLEMg4e9BiP Ty21zNWIMW7kBoq095MKBn+czh7Yi11LUqoWQIIHvLx5jL3Jln9TF///m5YbbwKnEU3m pmANoOShjcanYPHc5eJsdVXOqgvwFajvxrpT4YRF+7dp/A3siBYx1Iu685eWXevT1RXn nBqa6y8gRQW/5P7kf0M4L85oOVKCUm93olocnemdOgoSOGv8wZWOpHWo+ceW5yuIER2y VUUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y10si3587810edt.393.2020.05.16.13.57.50; Sat, 16 May 2020 13:58:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbgEPUxi (ORCPT + 99 others); Sat, 16 May 2020 16:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726592AbgEPUxi (ORCPT ); Sat, 16 May 2020 16:53:38 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9346DC061A0C; Sat, 16 May 2020 13:53:38 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CAA94119445C7; Sat, 16 May 2020 13:53:37 -0700 (PDT) Date: Sat, 16 May 2020 13:53:36 -0700 (PDT) Message-Id: <20200516.135336.2032300090729040507.davem@davemloft.net> To: xulin.sun@windriver.com Cc: alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xulinsun@gmail.com Subject: Re: [PATCH] net: mscc: ocelot: replace readx_poll_timeout with readx_poll_timeout_atomic From: David Miller In-Reply-To: <20200515031813.30283-1-xulin.sun@windriver.com> References: <20200515031813.30283-1-xulin.sun@windriver.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 May 2020 13:53:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xulin Sun Date: Fri, 15 May 2020 11:18:13 +0800 > BUG: sleeping function called from invalid context at drivers/net/ethernet/mscc/ocelot.c:59 > in_atomic(): 1, irqs_disabled(): 0, pid: 3778, name: ifconfig > INFO: lockdep is turned off. > Preemption disabled at: > [] dev_set_rx_mode+0x24/0x40 > Hardware name: LS1028A RDB Board (DT) > Call trace: > dump_backtrace+0x0/0x140 > show_stack+0x24/0x30 > dump_stack+0xc4/0x10c > ___might_sleep+0x194/0x230 > __might_sleep+0x58/0x90 > ocelot_mact_forget+0x74/0xf8 > ocelot_mc_unsync+0x2c/0x38 > __hw_addr_sync_dev+0x6c/0x130 > ocelot_set_rx_mode+0x8c/0xa0 Vladimir states that this call chain is not possible in mainline. I'm not applying this.