Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1540855ybk; Sat, 16 May 2020 14:54:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqJoAqVmBVvutuhpfrxy4KWsd7Ebpfix8uU8BYviNKnz+S2YWZzHdhJPyOvBBAOE/jBdVC X-Received: by 2002:a50:f385:: with SMTP id g5mr7316212edm.2.1589666048201; Sat, 16 May 2020 14:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589666048; cv=none; d=google.com; s=arc-20160816; b=BogQjooHAABI+6ULsKJ+vTxgRXcNd12r8RUW3bUwY5dLYlJ6U6s/A9FGMIuv3SQl5j +Mb8D+TZO0fgoNyNOaq3+vi5trW2EK8XISLC2tHzhrpeGAF/1bdWEh7IJSvkmuDzTphf pp2LDhsxKHEf9JE6HPiGn6Fj6ZlvApti1BdSL6XIUbTHIq3+KyA0DxIHsj/vG8mAZPqZ ORFyJ/syxXaV6fq8nf/HiUiBkKOSnbGJCPb4jdg6w5J7j3GijyvkA+aSRiVgZUACzjkZ hd8VRmsYiLPUpLw0xvOIJdifGIetL8D3WroKvMiicaXfvU92ROrnMPJnM59bmFPh+v7H PQ0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xiwtAtYu45iFXDcDagg5aGZp3J1GaKnWUnkhlQPNwrQ=; b=QOpGdjrMR1efC+ik0uh+BLRrkh77ZtirJ6m0/oxLx+l8ClohZbPDNQrQ4tVPdxWuMs R06QBUSWw63/pCWvqzC7Ril+gF5dNmo4sk0DHDSyDsciu4Mb6w+O+Vx1frg3bxHI807v 4GYsTGTtSZC8K13TbSz6yDL6Q+JyOoO8Pxq/EZ9abBij/7atqIxLIlajHxhauhLY6707 W8vItANZdvl+D8Ml2Iqf9CvRun8pNKDdXob3LV2u8W8QwY1CQvy79CbYRlD+VoMr1S03 niInCUyG+3x+FD6cafGHB1tFcFk8FfKMu+7kk4recJY5rqiUhH/aMFzy5zZ8W9zJuKC2 2Tjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@crapouillou.net header.s=mail header.b=hLiE2p98; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y67si3950030ede.584.2020.05.16.14.53.45; Sat, 16 May 2020 14:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@crapouillou.net header.s=mail header.b=hLiE2p98; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726972AbgEPVvt (ORCPT + 99 others); Sat, 16 May 2020 17:51:49 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:46924 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726660AbgEPVvt (ORCPT ); Sat, 16 May 2020 17:51:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1589665874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xiwtAtYu45iFXDcDagg5aGZp3J1GaKnWUnkhlQPNwrQ=; b=hLiE2p98/HJlrqner3vfu136buvMUH01+JbjHiA1cV2YzReQ0BXaNKeu1QgvG4Ye7fim3t tFDT3/KiduYBJ2gEqqJIe16FuofXRzkRax25LVaLBlSJVv2wbuKDqOFp2ysKILMuy+EVUT qxmafI3wwXgG3qCTfaVAZVgmlqn34Rc= From: Paul Cercueil To: David Airlie , Daniel Vetter , Rob Herring , Greg Kroah-Hartman , "Rafael J . Wysocki" Cc: od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil , stable@vger.kernel.org Subject: [PATCH 06/12] gpu/drm: Ingenic: Fix incorrect assumption about plane->index Date: Sat, 16 May 2020 23:50:51 +0200 Message-Id: <20200516215057.392609-6-paul@crapouillou.net> In-Reply-To: <20200516215057.392609-1-paul@crapouillou.net> References: <20200516215057.392609-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org plane->index is NOT the index of the color plane in a YUV frame. Actually, a YUV frame is represented by a single drm_plane, even though it contains three Y, U, V planes. Cc: stable@vger.kernel.org # v5.3 Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c index 97244462599b..3207105755c9 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane, addr = drm_fb_cma_get_gem_addr(state->fb, state, 0); width = state->src_w >> 16; height = state->src_h >> 16; - cpp = state->fb->format->cpp[plane->index]; + cpp = state->fb->format->cpp[0]; priv->dma_hwdesc->addr = addr; priv->dma_hwdesc->cmd = width * height * cpp / 4; -- 2.26.2