Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1671369ybk; Sat, 16 May 2020 19:42:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL/7EEATqQyZy2NiCm9ZJpSUnmX+ngLbsht10ztqvHnD2U4NCf3FunOAU65bE59lIpT7Gl X-Received: by 2002:aa7:c0d1:: with SMTP id j17mr8648497edp.308.1589683365942; Sat, 16 May 2020 19:42:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589683365; cv=none; d=google.com; s=arc-20160816; b=kK0Pt/XQ5v7CjpXGHLK8Xq0fAD4lAF/vq0bS4H1vlyLPMjyx0zU+UXBugLKbzQGNUO P7xE6wXns6etSWefYg9lgsc7pwAy6z+vFAvusyFRxJrRJvjhcx4NUtOykP+4agm/oJVx ztnGyZ7mt0YZ8bhP2YdMj+ODQ72ab1WReTioUs/It2cYTzcdpBljL8S9MmeHeNOhZ0hg ew++8XgLwfL1ClRc4oO8+IsSTsVi5b4d8h6+ImgX8K+JNn5XSaQiErEXev9QTq73uXuu 6FN75WnaeGS/wtLxLxr+f56r+OcYTj5/uasJy7COp6Y38/nVkbku5G84aF0Be18SFcij gj0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=DQ7b10CExQtYq9ez/1sImqvzsTVJs9wfSvWwWE1m+zg=; b=d+DwALYqYDmVBhZEfyy1BSXBTC8Ml7ABZTCIYhKtzLjHAjrjLCUytn7hVTtSpDi8bp jbSncLwoiHR326/4Lieg3M5Q1i9jy0DyePLhqbwhYVfmyyyL28bZmwOYmBe+Ti+V5JMq tY+Bhn9Yk9EfLZUuwEQWkVssIivrBGhNRPZAEjVlkl6uAcbzcWNCj2akc7UG4bgZ/bIP jCZLtkRP9g8Ylp9SqJSxXBmVwGuqf4ToMXM2a9tnEDyyjZOz4e89bmSGmKWn2qvALTc4 qkBE7VmeWy8RoewRbxJjtk4jEDYwyy5F2opU/HR7qTwpEC3SqoO4l5x6gMNbdQBxirmp O4qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bW5p1lim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si4424176eju.98.2020.05.16.19.42.23; Sat, 16 May 2020 19:42:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bW5p1lim; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbgEQCkL (ORCPT + 99 others); Sat, 16 May 2020 22:40:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726919AbgEQCkJ (ORCPT ); Sat, 16 May 2020 22:40:09 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614B1C05BD09 for ; Sat, 16 May 2020 19:40:08 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id x77so3067538pfc.0 for ; Sat, 16 May 2020 19:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DQ7b10CExQtYq9ez/1sImqvzsTVJs9wfSvWwWE1m+zg=; b=bW5p1limV5v31ZEEUmeY80kPntKeAP7HeTDpzq0pJU+hfaLfTwsI5yetINIu44YNQ4 snELtQQy2ES70Hvlzy5NGA1e2Vll6u48YlTY0+Jj47MitzVgDBJHZ/k/jcQlNILqn1Cc rJJD6QDtv+5OQCka5Eyr0n6VANGZDd85j6Bo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DQ7b10CExQtYq9ez/1sImqvzsTVJs9wfSvWwWE1m+zg=; b=Rsx3NoN6y06T/yAYq2R2miaNJXNsYYzkAEIs6n6zaLBYx1hPEryysv+83Uhn1di5Tm vlnA1bxsOi5z3PepEtY8ezcivH7l1EOhZL2WcoIGMfuyJB62b1dmEOxf4hmTnuJraNXr VlLDgiVrbn5SExEiPM0KI4o4vSw9bBGlTPn7E4gTV59EdgqgaVlrhUAo3ojnnuWe+1a2 aJtcobQQnzhHSTv83Obh0g3uSk4UBpZaw+C5KIvyrZOmuSUcseLqctILJOhz5QubNTvo MXuOEbNty7uKGUbeUOaTGO5ehqKbJpdauEKuDBc2U3QCNORIrs8gBjJV5yDYW9rwZsXM cqtQ== X-Gm-Message-State: AOAM5319GwjMxTVF52HPaELr6fioJM4YtpXtU6CJ3sePIowpQr5Ur+xc hV5S8F2T6csK4EW/IV/ZYxTndg== X-Received: by 2002:aa7:93ac:: with SMTP id x12mr2880478pff.143.1589683207980; Sat, 16 May 2020 19:40:07 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id cm14sm4881606pjb.31.2020.05.16.19.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2020 19:40:07 -0700 (PDT) Date: Sat, 16 May 2020 19:40:05 -0700 From: Kees Cook To: Xiaoming Ni Cc: mcgrof@kernel.org, yzaikin@google.com, adobriyan@gmail.com, peterz@infradead.org, mingo@kernel.org, patrick.bellasi@arm.com, gregkh@linuxfoundation.org, tglx@linutronix.de, Jisheng.Zhang@synaptics.com, bigeasy@linutronix.de, pmladek@suse.com, ebiederm@xmission.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, wangle6@huawei.com Subject: Re: [PATCH v2 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals Message-ID: <202005161940.B8DF981@keescook> References: <1589619315-65827-1-git-send-email-nixiaoming@huawei.com> <1589619315-65827-3-git-send-email-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589619315-65827-3-git-send-email-nixiaoming@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 16, 2020 at 04:55:13PM +0800, Xiaoming Ni wrote: > Some boundary (.extra1 .extra2) constants (E.g: neg_one two) in > sysctl.c are used in multiple features. Move these variables to > sysctl_vals to avoid adding duplicate variables when cleaning up > sysctls table. > > Signed-off-by: Xiaoming Ni Reviewed-by: Kees Cook -- Kees Cook