Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1673629ybk; Sat, 16 May 2020 19:48:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvnjKQZwjSXaCvY0r/j3sWOINzgHq1G0jl8+/noeY5+uR4/4+ncATsB2QS561zMio8GPQj X-Received: by 2002:a17:906:1659:: with SMTP id n25mr9829205ejd.122.1589683694730; Sat, 16 May 2020 19:48:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589683694; cv=none; d=google.com; s=arc-20160816; b=gvRYvyLAvLs47EADkoFEQfPipobNvoIEcBgrZmPwGoucayWNFk3r6AmndHFBLgUzVr QKsuBENtb8WektdreX1M4OY+XPMo0dV0h7YeFu4X8gsNUgNzD5N69T26WR5MdAKxgA+L jy7dwi+fzaGafCAjDR2TQ9Etam28+JlZOxcLdEQA/6fKTn9eeLtu9xay7nrK4PyTGy3F BaBd0yAADjJ5fQ4mYyg/x6Wz9IS1MIJUkNF6mz0gk45Ap4N9LjIcE+VuMVXVgDuRzJR9 mr1ykk75O/coqq8E/YKY/5UStDGnM01i+jQlCzCpxrLSYVGTbx9FdhREwnl88zl1k47H eiMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=hxqibz6u//AudMT2I1ARGsf1Me7UhpEYD8y+pnhWIpY=; b=qkmV6LXbE+vkuldxB8TTZ1ZeD9MAPRIpiIKCCgwTTB0gHEkTW3Jdku8G5HtMXlBtuQ 5UxxF9M7RMdCRZwc3gSddujVTbDrjyeKv2WZYCvq3vh5kxwPSsc3TTOKkqwERq53iSiZ /rWxjOzACuc5Q9RUJIxKIE+GT4XKni3CyHjl11aSwTSv+4/ciS10fDReQ+6LUhCa4b9i OI3AN1libTsbhh0hY56JBjvYiYffVG/w9w2WMo/yqWwfoNuceU8eG2g+DPZHnUdHrJNU fwC/2VknF/fSx1797qjZor1cKrEsG9djLjgSyoFWfelHjC8iR9z539PaY0cfCStKgAIs LOjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=d3cstiY6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p1si4143637ejd.333.2020.05.16.19.47.52; Sat, 16 May 2020 19:48:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=d3cstiY6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727000AbgEQCoW (ORCPT + 99 others); Sat, 16 May 2020 22:44:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgEQCoV (ORCPT ); Sat, 16 May 2020 22:44:21 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 487DEC061A0C for ; Sat, 16 May 2020 19:44:20 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id x77so3069819pfc.0 for ; Sat, 16 May 2020 19:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hxqibz6u//AudMT2I1ARGsf1Me7UhpEYD8y+pnhWIpY=; b=d3cstiY6gDBn4aMz8bpUhxxoMwZGVOHwN8YofmIdJRCHvyLUctClFeHYQOcqqBJFvR G8YNmf06SK9P79w1RZojxbv8wsLCoyhs969+9o2C/XmI3PTSno2Rgr8Rsil1KFZ5l/s/ azsLDeoU7EiBDYz4zxzLKClh0LKrQA8N/j6eo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hxqibz6u//AudMT2I1ARGsf1Me7UhpEYD8y+pnhWIpY=; b=mFF3hJXPeTFSRqj/bf+yg1xhuXnBm+Hkpl5pXH4MZjpnlgYmqrWcabVzANRmiYdAjE IGxOVhmQXbxcdxLkHU4tPIz7X+8Gj6ApLmIpp9IRZelBwwyq8Ja/0Po3MTHkaZ+3121f 9iYj4DFzAFfWKiYtNTdA9Y2rRdG337X8Rb2KS7UvKW9EdjndGcLabUyg5ofHig2kkG8I P4/hfgFMTD4veZjIZ7wXVvY3eqvwDRJa39DiZ4TTXqTh9kQtj+TPdEmKBMz0+IVr87Vh 02iKUkB05sGHp8FTM6PmhnGxi7hRP2WloaTlOKEzIB2bujFKvYS/+691luyLULlGQtcW 3KcQ== X-Gm-Message-State: AOAM5306GkzeIes8aJNubUbPRjuyZLb6zkmVx+ACpy8i0wFLRHIfVEPg HAWvnOInO/qCWpsKhkLJZzENxA== X-Received: by 2002:a62:2fc4:: with SMTP id v187mr10683638pfv.312.1589683459911; Sat, 16 May 2020 19:44:19 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z6sm4662345pgu.85.2020.05.16.19.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2020 19:44:19 -0700 (PDT) Date: Sat, 16 May 2020 19:44:18 -0700 From: Kees Cook To: Xiaoming Ni Cc: mcgrof@kernel.org, yzaikin@google.com, adobriyan@gmail.com, peterz@infradead.org, mingo@kernel.org, patrick.bellasi@arm.com, gregkh@linuxfoundation.org, tglx@linutronix.de, Jisheng.Zhang@synaptics.com, bigeasy@linutronix.de, pmladek@suse.com, ebiederm@xmission.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, wangle6@huawei.com Subject: Re: [PATCH v2 4/4] watchdog: move watchdog sysctl interface to watchdog.c Message-ID: <202005161944.75CFAD8@keescook> References: <1589619315-65827-1-git-send-email-nixiaoming@huawei.com> <1589619315-65827-5-git-send-email-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589619315-65827-5-git-send-email-nixiaoming@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 16, 2020 at 04:55:15PM +0800, Xiaoming Ni wrote: > Move watchdog syscl interface to watchdog.c. > Use register_sysctl() to register the sysctl interface to avoid > merge conflicts when different features modify sysctl.c at the same time. > > Signed-off-by: Xiaoming Ni Reviewed-by: Kees Cook -- Kees Cook