Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1760550ybk; Sat, 16 May 2020 23:19:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjIIj2ezKizTnQt6oe5p9mBBqID1JhlJnIUG3fx3TO5PqNyZXvA7q9u15rEDi7nWCYz80u X-Received: by 2002:a17:906:7e43:: with SMTP id z3mr3432332ejr.221.1589696389392; Sat, 16 May 2020 23:19:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589696389; cv=none; d=google.com; s=arc-20160816; b=iRjXEGtJ620rRKreL8JmXc9Wp+zH0xaX/Fax6RQIp1S+/ErQLaKZhYEKxzgGkp8wJw M3NISA8O4TpdfIwl0CproyjaPEx93zaE8OcF6Uu6sSXQ+y1GpU7yMoT5mXP95yhMt2Wi NwllEohBDIZXt3MIK335ugdDcmS53ma86T/Ujgw8iv2Wz5S5rvpxn8ISektlSrppXL2p rANdD0dEAoHeJe9oECMl/U3myEiDB8BIP4et9uxJEqSl25TWwgUwL8wE19HQJNvcP7jN S6qZZeLPR/k9M5+y/wl+3/1SzBtScjSGi9tGQw2AEznFp5+9LvwAkZ07P9vHYqxuzvqo 0fwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=A3cnQwSGkMXCStINvvcSBWeYAFL20NpAZfAlm2Cyzck=; b=ASVMbN4+m4vNJFI/0nRv2k2ACZ/G0vEp0m0bb8lvQeWQTfBp8HC6sI9MLQo225TFIa gBiX2E1Z82dsXXJPiAXu3blkDAwoIsXkQu8MloH6jwvQu7PiSR3b3qEdjxV1neUzMdvp QzYDVBupL4Xg39A2Jt+ybNvP4iFMvquoHN18Cn+afHBZzDNNi878YTP1UvUro0O7mNqe /R9Xe6DRBKEV0u+EQ5Ke5cOu1zh9iIVgcOxVg0ZiR0g6rX4edyktcS8CQTh7AEiyxwng 4rxX0dcj2CTrcjSrsCQi73+JWrFe76HhcjE2ByNkeeRm7fXHHGb5/BHf+yYe+OjtB1TK npSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si4444854ejz.137.2020.05.16.23.19.26; Sat, 16 May 2020 23:19:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbgEQGRm (ORCPT + 99 others); Sun, 17 May 2020 02:17:42 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:51790 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbgEQGRm (ORCPT ); Sun, 17 May 2020 02:17:42 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id C667780533; Sun, 17 May 2020 08:17:38 +0200 (CEST) Date: Sun, 17 May 2020 08:17:37 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: David Airlie , Daniel Vetter , Rob Herring , Greg Kroah-Hartman , "Rafael J . Wysocki" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, od@zcrc.me, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 04/12] gpu/drm: ingenic: Fix bogus crtc_atomic_check callback Message-ID: <20200517061737.GC609600@ravnborg.org> References: <20200516215057.392609-1-paul@crapouillou.net> <20200516215057.392609-4-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516215057.392609-4-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=VwQbUJbxAAAA:8 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=q0884fTdi5gFdvFPT1AA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 16, 2020 at 11:50:49PM +0200, Paul Cercueil wrote: > The code was comparing the SoC's maximum height with the mode's width, > and vice-versa. D'oh. > > Cc: stable@vger.kernel.org # v5.6 > Fixes: a7c909b7c037 ("gpu/drm: ingenic: Check for display size in CRTC atomic check") > Signed-off-by: Paul Cercueil Looks correct. Acked-by: Sam Ravnborg > --- > > Notes: > This patch was previously sent standalone. > I marked it as superseded in patchwork. > Nothing has been changed here. > > drivers/gpu/drm/ingenic/ingenic-drm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c > index 632d72177123..0c472382a08b 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c > @@ -330,8 +330,8 @@ static int ingenic_drm_crtc_atomic_check(struct drm_crtc *crtc, > if (!drm_atomic_crtc_needs_modeset(state)) > return 0; > > - if (state->mode.hdisplay > priv->soc_info->max_height || > - state->mode.vdisplay > priv->soc_info->max_width) > + if (state->mode.hdisplay > priv->soc_info->max_width || > + state->mode.vdisplay > priv->soc_info->max_height) > return -EINVAL; > > rate = clk_round_rate(priv->pix_clk, > -- > 2.26.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel