Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1844532ybk; Sun, 17 May 2020 02:23:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3O7Fo8RFPiKWK7ls6ujq3cTwKJPmZXsRdgEIA6hjE+8tAsXo8CTtj5l6wzZ/SPd6zhy6r X-Received: by 2002:a17:906:7b52:: with SMTP id n18mr10817617ejo.292.1589707395837; Sun, 17 May 2020 02:23:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589707395; cv=none; d=google.com; s=arc-20160816; b=HCnR3J1ZEBgOV1rQX/m9B+/ablvj9alSodgfBfD343y9MORugLSyojkmHxBChFQPFn +4a6A4zrOWvBomh1JpMw1HFX48JuCmmB0IPYN6bbSfup4H0YKaDkDsCJ7dR+rtOb1SHK Xlf+X72VJZyIdVM1j/w5b0NdX8en0ku3FEEEwspZE1VwAswrOBcRqBBdnrX3q8kj0FJi zR5SyoTTyLIT7Vt17ob4rG51h23fqzMDBfOjTAU+iLA3+vKApZ/+jEwFxIVilFhTsLXD fonq/6l/5U3RaXZ4coGdr7+IgvqONE5sWmQFTbLoV2I0FspLOxCs4y5QhtAdOeh9ZRqQ r2Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=EZN0CULOm4NwZwJjvBqZsRyMbaIBRiK1d1VBS60zGhY=; b=OnSnQnY14BagaHzBjjhhdTfebD8PduXT2BDAEh4JHHAppk2ynhsTFTn8WrgAogHfAW 06l9CZMWiUwOcb8w6QA84JAiPNSSwKcDufIsYXCTuX1KjJoovu1aaTMArYZi6KuuKQsS 8pxuSVit9qdlY7nEiJ2TonYDfcCSHEr85F3Xgc5+LEdjkGJYvZ20BE9FewFpI82StSaQ 7OWWaIfnF307sn430FLuRUavbQ1mm1xVzncQgboIGb904kMw4H7oOSdRUAl+XjddDuSl L8yzgxzGq8Hpb2upBU/29FPF6in6ENEAOsaOjRlFdieQ1HEdXhTl+0sAa51Dl3Dt6Fu7 +GQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=dDaGq5dK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si4032921edy.1.2020.05.17.02.22.39; Sun, 17 May 2020 02:23:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=dDaGq5dK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbgEQJUv (ORCPT + 99 others); Sun, 17 May 2020 05:20:51 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:47698 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727043AbgEQJUv (ORCPT ); Sun, 17 May 2020 05:20:51 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589707249; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=EZN0CULOm4NwZwJjvBqZsRyMbaIBRiK1d1VBS60zGhY=; b=dDaGq5dKp29PO0JbI2YXPpNbN8g7nJk6bz+8b3DXTaLYoj9d3hjgjyst47/qXTnZnlbX7K6Y ZqzeKYFVZLFRb3w+JGMSVpJEorMhllnnRo3RvILUu0Zh57Egceu7dRB52gWSwca+QCjB9sSQ s9KYnFp6Nd8ZYscp1fNeloTvUXA= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5ec101f05d62762fd427d2c2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 17 May 2020 09:20:48 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BB5EBC43637; Sun, 17 May 2020 09:20:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.0.102] (unknown [183.82.140.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tdas) by smtp.codeaurora.org (Postfix) with ESMTPSA id B94E1C433D2; Sun, 17 May 2020 09:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B94E1C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tdas@codeaurora.org Subject: Re: [PATCH v1 2/4] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180 To: Rob Herring Cc: Stephen Boyd , Michael Turquette , David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , devicetree@vger.kernel.org References: <1585338485-31820-1-git-send-email-tdas@codeaurora.org> <1585338485-31820-3-git-send-email-tdas@codeaurora.org> <20200405020946.GA6110@bogus> From: Taniya Das Message-ID: Date: Sun, 17 May 2020 14:50:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200405020946.GA6110@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, Thanks for the review. On 4/5/2020 7:39 AM, Rob Herring wrote: >> + >> + reg: >> + minItems: 1 >> + maxItems: 2 > > Need to define what each one is when there are 2. > Yes will define them in the next patch. >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - '#clock-cells' >> + - '#power-domain-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + clock-controller@63000000 { >> + compatible = "qcom,sc7180-lpasshm"; >> + reg = <0 0x63000000 0 0x28>; >> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; >> + clock-names = "gcc_lpass_sway"; >> + #clock-cells = <1>; >> + #power-domain-cells = <1>; >> + }; >> + >> + - | >> + clock-controller@62d00000 { >> + compatible = "qcom,sc7180-lpasscorecc"; >> + reg = <0 0x62d00000 0 0x50000>, >> + <0 0x62780000 0 0x30000>; >> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>; >> + clock-names = "gcc_lpass_sway"; >> + power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; >> + #clock-cells = <1>; >> + #power-domain-cells = <1>; >> + }; >> +... > /* GCC resets */ >> #define GCC_QUSB2PHY_PRIM_BCR 0 >> diff --git a/include/dt-bindings/clock/qcom,lpasscorecc-sc7180.h b/include/dt-bindings/clock/qcom,lpasscorecc-sc7180.h >> new file mode 100644 >> index 0000000..9466d5e >> --- /dev/null >> +++ b/include/dt-bindings/clock/qcom,lpasscorecc-sc7180.h >> @@ -0,0 +1,28 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) 2020, The Linux Foundation. All rights reserved. >> + */ >> + >> +#ifndef _DT_BINDINGS_CLK_QCOM_LPASS_CORE_CC_SC7180_H >> +#define _DT_BINDINGS_CLK_QCOM_LPASS_CORE_CC_SC7180_H >> + >> +/* LPASS_CORE_CC clocks */ >> +#define LPASS_LPAAUDIO_DIG_PLL 0 >> +#define LPASS_LPAAUDIO_DIG_PLL_OUT_ODD 1 >> +#define CORE_CLK_SRC 2 >> +#define EXT_MCLK0_CLK_SRC 3 >> +#define LPAIF_PRI_CLK_SRC 4 >> +#define LPAIF_SEC_CLK_SRC 5 >> +#define LPASS_AUDIO_CORE_CORE_CLK 6 >> +#define LPASS_AUDIO_CORE_EXT_MCLK0_CLK 7 >> +#define LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK 8 >> +#define LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK 9 >> +#define LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK 10 >> + >> +/* LPASS power domains */ >> +#define LPASS_CORE_HM_GDSCR 0 >> + >> +#define LPASS_AUDIO_HM_GDSCR 0 > > Kind of odd that 2 are the same value. > These GDSCs are from two different domains. I will update the comments in the next patch. >> +#define LPASS_PDC_HM_GDSCR 1 >> + >> +#endif >> -- >> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member >> of the Code Aurora Forum, hosted by the Linux Foundation. >> -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --