Subject: Re: [PATCH] Fix SCO on Broadcom Bluetooth adapters
From: Marcel Holtmann <marcel@holtmann.org>
To: Olivier Galibert <galibert@pobox.com>
Cc: "Hack inc." <linux-kernel@vger.kernel.org>, maxk@qualcomm.com,
       bluez-devel@lists.sourceforge.net
In-Reply-To: <20060314111248.GA75477@dspnet.fr.eu.org>
References: <20060314111248.GA75477@dspnet.fr.eu.org>
Content-Type: text/plain
Date: Tue, 14 Mar 2006 14:49:03 +0100
Message-Id: <1142344144.4448.3.camel@aeonflux.holtmann.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1050
Lines: 30

Hi Olivier,

> Broadcom USB Bluetooth adapters report a maximum of zero SCO packets
> in-flight, killing SCO.  Use a reasonable count instead in that case.
> 
> Signed-off-by: Olivier Galibert <galibert@pobox.com>
> 
> ---
> 
> I don't think that could be reasonably done as a quirk.  Simple
> examination of the .inf coming with the windows driver shows that 100+
> different models may be having this problem.  Also, it can't break
> already working adapters, so why bother.

your patch might break devices where this value is chosen on purpose, so
it is not acceptable and must be done with a quirk. Another reason is
that I don't allow any stupid vendor specific workarounds inside the
Bluetooth core unless they are implemented as quirks. The core has no
vendor information at all.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/