Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1920490ybk; Sun, 17 May 2020 04:54:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7+LcJ8rEExeijB/KJF3Tp4XhD2HZoHFnFjihmiJrZ9scyZrJCRlRbL3F0lH6w6w0Nf7tw X-Received: by 2002:a17:906:2b96:: with SMTP id m22mr10794607ejg.330.1589716445464; Sun, 17 May 2020 04:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589716445; cv=none; d=google.com; s=arc-20160816; b=CeCZb6WyGr33Jjyt2DImA83xOzOmMLlgwKggxL6LIYzTVt8QhwK+Ge5VaRID+roD+H tzErZKVaxJX617Tv+lqcLFV91sjjB8TSL7QQi1hzIO2UCUbxIf/ZwVHObrBnDSxCT0ng a1SC+FVpQePOlHsWyW96sTtaEyGvjTl8ubtT1fScoZ2adShQx3YyEITYmLQ+FsqYch6Q kb8Rew/WbOaP3tAGiKmrHPw1jam/Zzwgw9xzMIt2ics2cFZCEAy0IlulW7hTTZEtDtvv 7PA7S3advNubWlXbH99Fs2DgrSIM4CEQQcUvQ9MpIKMZtgZvLY7bw92+7YFn0+xMvFOZ Ujyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=RQqCyR4bauMcLEGGbKHO9FQ26y1JMcu6L0Mz2chabH4=; b=Fd/RzuB4J3jOpuJ9qHz0gpVt+/35U6IEEAgoRdR9pIjo2Wt2uu5efedt0ZHvfhzVtb sYPYk9+Cdg9HwFMMn4q08a+zS2NzApmW0Wf1r9XzIVwSmhX0JGSdAMXO3+7pC9UAHTD+ 0c3nhSK0A9Z4Zw9E4+YjNZO3edm7MfP1//JhcsiurH0soeT0YMXHVfjWjPi5UwrZZQ9b yv7Ih6QAlQA25pzKQjoNf/aIjo7I1lwFZaOiPTO8KgIWOzJDUWzgTqFvtuLv8/8jS9l1 /3Po0wQBIYzF+AVRI2Svma1hYJBYh3OZBg4aCW4rG3fc688D5zLxnPEzSvPfPUDMXUk1 aPVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TPK6UhYz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u27si4464850edb.377.2020.05.17.04.53.10; Sun, 17 May 2020 04:54:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TPK6UhYz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727918AbgEQLuJ (ORCPT + 99 others); Sun, 17 May 2020 07:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727833AbgEQLuJ (ORCPT ); Sun, 17 May 2020 07:50:09 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092BCC061A0C; Sun, 17 May 2020 04:50:09 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id f15so2980279plr.3; Sun, 17 May 2020 04:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RQqCyR4bauMcLEGGbKHO9FQ26y1JMcu6L0Mz2chabH4=; b=TPK6UhYz1SmNZpLvbYJP2NFkB4VEnM1LAp3SFhb6dijjHxHPOVYj6mPJCuzeut/Ihd CdfrZacKNWM2ik+Z1ra2/zwMjcP1as1cGPQMnZRqA8x4/3lwqQB5wdHepYJynSn+7u7e bgDtKINcFBGn7wpsLvdT3iwn5VLR5hYjIx9BYTg2vD/4N2vCHWvR9vCL5qa0xXZELQ55 rFZayqMTXCSRoE87RGCc1v7hvQJ6QXSctqeApFtHISQH3Dir/ZfDOIKM/LnYMQiXHrd2 8CHb47vAyVcRcdImLO4QO2/ZX0JWuAF/ldMJSNAJpEUrxj1hNPXdvKrkWjvb7eGsn6mQ 0ubQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RQqCyR4bauMcLEGGbKHO9FQ26y1JMcu6L0Mz2chabH4=; b=IaMBK4ICpDekRQcZXNx5nf5shavli7haCf57aam/CZouuhYJFv24SqdP54u9nMziab OSUw28wjxt9+/+UymL+2790Eo+3lXqxLVWR9dldQJLGzF1aI6pM9rryU0yVTHQWcZpTL 3tAbETJVeKU+SRVj1XJsQrBm5SzuowUmcd+Wm3WTJfJSCvtrvg+jN2OUaYVf1nrI4r1+ PVWkTW1lbVoOCDoCLudW7FEFoaS6BzX/Q0O0esMiXd9/batA0CV/D+FB+8J6P91uStY5 9Ud1obY+t5AEReEJv+OupKEXv6zrN1JN4h9zKj/fgHhepYnUCIga0OFJyrg8VNAY4vc+ Lc1g== X-Gm-Message-State: AOAM531vO/6ECR3skm9O99U1myRAyHglrYMDdHMsEXSdxaA+1tsWR3RR 10P+lcSdigC9uVNmC1SOiSg0oWIw X-Received: by 2002:a17:90a:2610:: with SMTP id l16mr13174341pje.219.1589716208483; Sun, 17 May 2020 04:50:08 -0700 (PDT) Received: from localhost.localdomain ([45.135.186.16]) by smtp.gmail.com with ESMTPSA id cc8sm5842593pjb.11.2020.05.17.04.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2020 04:50:07 -0700 (PDT) From: Baolin Wang To: axboe@kernel.dk Cc: baolin.wang7@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] block: Remove unused flush_queue_delayed in struct blk_flush_queue Date: Sun, 17 May 2020 19:49:41 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The flush_queue_delayed was introdued to hold queue if flush is running for non-queueable flush drive by commit 3ac0cc450870 ("hold queue if flush is running for non-queueable flush drive"), but the non mq parts of the flush code had been removed by commit 7e992f847a08 ("block: remove non mq parts from the flush code"), as well as removing the usage of the flush_queue_delayed flag. Thus remove the unused flush_queue_delayed flag. Signed-off-by: Baolin Wang --- block/blk-flush.c | 1 - block/blk.h | 1 - 2 files changed, 2 deletions(-) diff --git a/block/blk-flush.c b/block/blk-flush.c index c7f396e3d5e2..b733f7ac75c7 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -258,7 +258,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error) blk_flush_complete_seq(rq, fq, seq, error); } - fq->flush_queue_delayed = 0; spin_unlock_irqrestore(&fq->mq_flush_lock, flags); } diff --git a/block/blk.h b/block/blk.h index fc00537026a0..6cab33a11f90 100644 --- a/block/blk.h +++ b/block/blk.h @@ -19,7 +19,6 @@ extern struct dentry *blk_debugfs_root; #endif struct blk_flush_queue { - unsigned int flush_queue_delayed:1; unsigned int flush_pending_idx:1; unsigned int flush_running_idx:1; blk_status_t rq_status; -- 2.17.1