Date: Tue, 14 Mar 2006 08:35:15 -0600
From: Robert Hancock <hancockr@shaw.ca>
Subject: Re: procfs uglyness caused by "cat"
In-reply-to: <5Qfgo-3At-15@gated-at.bofh.it>
To: Herbert Rosmanith <kernel@wildsau.enemy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Message-id: <4416D4A3.9070705@shaw.ca>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
References: <5Qfgo-3At-15@gated-at.bofh.it>
User-Agent: Thunderbird 1.5 (Windows/20051201)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 28

Herbert Rosmanith wrote:
> a simple way to get rid of this:
> 
> static int uptime_read_proc(char *page, char **start, off_t off,
>                                  int count, int *eof, void *data)
> {
>         struct timespec uptime;
>         struct timespec idle;
>         int len;
>         cputime_t idletime;
> 
> +	if (off)
> +		return 0;

Except that this is wrong - if you try to advance the offset a bit from 
the start of the file and read something, you'll get nothing. This is 
inconsistent with normal file behavior.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/