Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 17 May 2020 10:52:20 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Guo Ren <guoren@linux.alibaba.com>
Cc:     linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] csky: Fixup calltrace panic
Message-ID: <20200517175220.GA48379@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Wed, May 13, 2020 at 03:15:25PM +0800, Guo Ren wrote:
> The implementation of show_stack will panic with wrong fp:
> 
> addr    = *fp++;
> 
> because the fp isn't checked properly.
> 
> The current implementations of show_stack, wchan and stack_trace
> haven't been designed properly, so just deprecate them.
> 
> This patch is a reference to riscv's way, all codes are modified from
> arm's. The patch is passed with:
> 
>  - cat /proc/<pid>/stack
>  - cat /proc/<pid>/wchan
>  - echo c > /proc/sysrq-trigger
> 
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>

This patch results in:

gcc version: csky-linux-gcc (GCC) 9.3.0

Building csky:defconfig ... failed
--------------
Error log:
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/devicetable-offsets.s] Error 1
make[2]: *** Waiting for unfinished jobs....
csky-linux-gcc: error: unrecognized command line option '-mbacktrace'; did you mean '-fbacktrace'?
make[2]: *** [scripts/mod/empty.o] Error 1
make[1]: *** [prepare0] Error 2
make: *** [sub-make] Error 2

when trying to build csky images with upstream gcc 9.3.0.

What version of gcc is needed to build csky images ? Also, would it be
possible to support the upstream version of gcc ?

Thanks,
Guenter