Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932205AbWCNPMh (ORCPT ); Tue, 14 Mar 2006 10:12:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932282AbWCNPMh (ORCPT ); Tue, 14 Mar 2006 10:12:37 -0500 Received: from nproxy.gmail.com ([64.233.182.204]:4084 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S932205AbWCNPMg convert rfc822-to-8bit (ORCPT ); Tue, 14 Mar 2006 10:12:36 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Lfz+HTyWhRhGCejSMeMP44WU66ZIasYeRhIh1aOluVKTrM/Ccx29XF2W+1q+4lv5+9ehFx9R8yNlqmpd542+CYvVWlwZRdHYEo74F1EXeeVR84/MuSFTVgYM02v2Ehe5Di6AieNCG/zJjUaGFUzXG4Vc3JZ8S64mANVkIhFtsd4= Message-ID: Date: Tue, 14 Mar 2006 10:12:33 -0500 From: "Bob Copeland" To: "Arjan van de Ven" Subject: Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver Cc: "Jeff Garzik" , "Ed Lin" , "Andrew Morton" , "linux-scsi@vger.kernel.org" , "promise_linux@promise.com" , "linux-kernel@vger.kernel.org" In-Reply-To: <1142329204.3027.26.camel@laptopd505.fenrus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <1142327906.3027.24.camel@laptopd505.fenrus.org> <44168C86.8060107@garzik.org> <1142329204.3027.26.camel@laptopd505.fenrus.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 19 On 3/14/06, Arjan van de Ven wrote: > On Tue, 2006-03-14 at 04:27 -0500, Jeff Garzik wrote: > > I thought that was unnecessary if the struct members are ordered such > > that compiler would not add padding? > > the rules for when padding gets added are different for each platform > though; worst case of adding it is that it serves as documentation that > the layout matters :) I thought the worst case of adding it is that GCC produces awful code when accessing structure members for __attribute__((packed)) items[1]. Maybe -Wpadded would be better? [1] http://marc.theaimsgroup.com/?l=linux-kernel&m=108829229128091 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/