Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbWCNP0E (ORCPT ); Tue, 14 Mar 2006 10:26:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932113AbWCNP0E (ORCPT ); Tue, 14 Mar 2006 10:26:04 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:50628 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932105AbWCNP0B (ORCPT ); Tue, 14 Mar 2006 10:26:01 -0500 Date: Tue, 14 Mar 2006 15:25:59 +0000 From: Christoph Hellwig To: Zachary Amsden Cc: Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn Subject: Re: [RFC, PATCH 3/24] i386 Vmi interface definition Message-ID: <20060314152559.GC16921@infradead.org> Mail-Followup-To: Christoph Hellwig , Zachary Amsden , Linus Torvalds , Linux Kernel Mailing List , Virtualization Mailing List , Xen-devel , Andrew Morton , Dan Hecht , Dan Arai , Anne Holler , Pratap Subrahmanyam , Christopher Li , Joshua LeVasseur , Chris Wright , Rik Van Riel , Jyothy Reddy , Jack Lo , Kip Macy , Jan Beulich , Ky Srinivasan , Wim Coekaerts , Leendert van Doorn References: <200603131801.k2DI1EAe005650@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200603131801.k2DI1EAe005650@zach-dev.vmware.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 16 On Mon, Mar 13, 2006 at 10:01:14AM -0800, Zachary Amsden wrote: > Master definition of VMI interface, including calls, constants, and > interface version. This is a totally horrible style. There's absolutely no need to find your own sized integer types, please use the standard kernel ones. Also don't use camel case and #pack but rather __attribute__. Also please avoid // comments. Also please remove all the historical version garbage, we don't care about that. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/