Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next] net: phy: realtek: add loopback support for
 RTL8211F
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
        <linux@armlinux.org.uk>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <kuba@kernel.org>,
        Yufeng Mo <moyufeng@huawei.com>,
        Jian Shen <shenjian15@huawei.com>
References: <1589358344-14009-1-git-send-email-tanhuazhong@huawei.com>
 <20200513131226.GA499265@lunn.ch>
From:   tanhuazhong <tanhuazhong@huawei.com>
Message-ID: <cb82153d-e14e-8e97-b3b8-210135fbdee6@huawei.com>
Date:   Mon, 18 May 2020 09:49:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20200513131226.GA499265@lunn.ch>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/5/13 21:12, Andrew Lunn wrote:
> On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote:
>> From: Yufeng Mo <moyufeng@huawei.com>
>>
>> PHY loopback is already supported by genphy driver. This patch
>> adds the set_loopback interface to RTL8211F PHY driver, so the PHY
>> selftest can run properly on it.
>>
>> Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
> 
> It took three people to write a 1 line patch?
> 
>> ---
>>   drivers/net/phy/realtek.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
>> index c7229d0..6c5918c 100644
>> --- a/drivers/net/phy/realtek.c
>> +++ b/drivers/net/phy/realtek.c
>> @@ -615,6 +615,7 @@ static struct phy_driver realtek_drvs[] = {
>>   		.resume		= genphy_resume,
>>   		.read_page	= rtl821x_read_page,
>>   		.write_page	= rtl821x_write_page,
>> +		.set_loopback   = genphy_loopback,
>>   	}, {
>>   		.name		= "Generic FE-GE Realtek PHY",
>>   		.match_phy_device = rtlgen_match_phy_device,
> 
> Do you have access to the data sheets? Can you check if the other PHYs
> supported by this driver also support loopback in the standard way?
> They probably do.
> 
> 	  Andrew
> 

Hi, Andrew.

There are two type of phys we are using, rtl8211f and "Marvell 88E1512".
"Marvell 88E1512" has already supported loopback
(f0f9b4ed2338 ("net: phy: Add phy loopback support in net phy framework")).
So now we adds loopback support to the rtl8211f.
 From the data sheet other phys should support this loopback as well, but
we have no way to verify it. What's your suggestion?

Thanks:)

> .
>