Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <2f78457e-f3a7-3bc9-e237-3132ee87f71e@gmail.com>
In-Reply-To: <2f78457e-f3a7-3bc9-e237-3132ee87f71e@gmail.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Mon, 18 May 2020 11:00:52 +0800
Message-ID: <CANRm+CyEfmmVHLWnkJ1YHX5r5bNd+QjPQWyr+pmVWM5a6CXorQ@mail.gmail.com>
Subject: Re: [PATCH] KVM: Fix the indentation to match coding style
To:     Haiwei Li <lihaiwei.kernel@gmail.com>
Cc:     "pbonzini@redhat.com" <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>, kvm <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 18 May 2020 at 09:32, Haiwei Li <lihaiwei.kernel@gmail.com> wrote:
>
> From: Haiwei Li <lihaiwei@tencent.com>
>
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
>
> Before fixing:
>
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
>                 }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>
> After fixing:
>
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
>                  }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>

Reviewed-by: Wanpeng Li <wanpengli@tencent.com>

>
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
> ---
>   arch/x86/kvm/x86.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
> -               }
> +               }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>                  data = kvm_read_edx_eax(vcpu);
> --
> 1.8.3.1