Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2577289ybk; Mon, 18 May 2020 02:38:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwThwKDlHR6QPQv5RXZEMa/BTo1WARJw7Cx3vq8eBbmiz8YJyJvrG5z4xUYdT3KFMuYorGH X-Received: by 2002:a50:f0ce:: with SMTP id a14mr12876134edm.131.1589794706419; Mon, 18 May 2020 02:38:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589794706; cv=none; d=google.com; s=arc-20160816; b=N6JtER1/Fo8+fJL1BorjeHPP8tGN72h6jglayQoch/UXjW5UA6ScDOGdjOlkYI4ykj RG7CnxOzNrMDxld2V02foIB/nNymy/NB2V1OkH6b7KDrQWw5zVAnvDWKFgyrO70mmMFn Gporfq+/wncFODk3QG64rj2JBF6Nro729zup2J02TIVgp7iMnT+yLv2Zjql4YxQ2ar2N r5aJMZ2sP5FDc479IGekaDy8EX9Wh8jDpMxSw7G8gPECc4QLwSrjjkI8Hg6UuN17T0bh Cb9yvVc4WI15QPVSwBB5YIFdsIpAKRWzmmoVeEpj+fzLPT8U4kXEu49uvYQN9GBeKMY+ kcOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2j4tkpm5JHeMcQSIOd5huHTdfscenHCGpDJTxFjuOQI=; b=WpE67c3KoSUUOuxw9VgJUZUx1CWnMWAcvCC1hSMPs/HcwE9tmM6u/J0NniIMGc09Jn YkATNRdEQdkNtxkDTd9EykkxbrqSbkSTxLMmKaHAUfyGPhffC8NDZp8esOFY2VqnAcms rNjzQGbUQILXt2ID+x73pLb6GXAuG/FGQoX7HkENu/Nn5jioGovEWkdsaPvHIGorgmx/ KZunKcBMgEqjwbV26LdU7hgY2hAE+QyB3boxoUA4eoS5CfI0BPLPSrSmqiHGoik3wLAJ ju6gdI7VaNakHxkFi0CS9cAM6DzBIxGHh8IPFGhCMHHuc2LEuqmiphw9nTYKvY1FuxY7 XhUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=M8ycmal7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c14si1426604edw.287.2020.05.18.02.38.03; Mon, 18 May 2020 02:38:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=M8ycmal7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbgERJeJ (ORCPT + 99 others); Mon, 18 May 2020 05:34:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgERJeJ (ORCPT ); Mon, 18 May 2020 05:34:09 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79C60C061A0C for ; Mon, 18 May 2020 02:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2j4tkpm5JHeMcQSIOd5huHTdfscenHCGpDJTxFjuOQI=; b=M8ycmal7zUd3GNKv6m41wBJcG2 uoyz6yFsIUKwbR+rIX97MHGtLVjExxNhILOnzMFyQVcR+si4Qeh1y9kjlsl+KDdjFIQzsiuEe8t9R woCrW5w1Bcy/kx4oSp2JUgFs4DjB9FoRxUsPvcqp3Ei+cc28aRbdexrNg9uvHWjWeHE5HXeq/FcEw vxeNw+aOweYB/WOhDE/WaZRclDl1wJeSYxwgWcRKnCroHI8dJ21O18i0VzGaG/aImQ3gwbXghLetd 7urT0HEjZ65/hrGS3APtnThBgapV4xHsQnJywpLBuovUUCYzQ8xdzMr6IOM5+b6FjN1yLd4w0YaLo M6dAvDLQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jac9s-0005EN-Py; Mon, 18 May 2020 09:34:04 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 29822300478; Mon, 18 May 2020 11:34:03 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E63EF2B3CFEEA; Mon, 18 May 2020 11:34:02 +0200 (CEST) Date: Mon, 18 May 2020 11:34:02 +0200 From: Peter Zijlstra To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, irogers@google.com, kim.phillips@amd.com, jolsa@redhat.com Subject: Re: [PATCH 3/3] perf/x86/rapl: add AMD Fam17h RAPL support Message-ID: <20200518093402.GB277222@hirez.programming.kicks-ass.net> References: <20200515215733.20647-1-eranian@google.com> <20200515215733.20647-4-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515215733.20647-4-eranian@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 02:57:33PM -0700, Stephane Eranian wrote: > +static struct perf_msr amd_rapl_msrs[] = { > + [PERF_RAPL_PP0] = { 0, &rapl_events_cores_group, NULL}, > + [PERF_RAPL_PKG] = { MSR_AMD_PKG_ENERGY_STATUS, &rapl_events_pkg_group, test_msr }, > + [PERF_RAPL_RAM] = { 0, &rapl_events_ram_group, NULL}, > + [PERF_RAPL_PP1] = { 0, &rapl_events_gpu_group, NULL}, > + [PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group, NULL}, > +}; Why have those !PKG things initialized? Wouldn't they default to 0 anyway? If not, surely { 0, } is sufficient.