Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2597478ybk; Mon, 18 May 2020 03:13:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznJRn9YTMxpQ9md68Qig/Gh+/9XjFSa6RwGxN1e7u80jiNLsVBvMHYcuhoE1KC5gfucw4o X-Received: by 2002:a05:6402:3044:: with SMTP id bu4mr13521867edb.342.1589796803039; Mon, 18 May 2020 03:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589796803; cv=none; d=google.com; s=arc-20160816; b=I3VE90KyhQoqHBYDjGh9AEM+yXAwz05JHSKnTlDTIWjTKmdCpORbLoYv+Z1+VP7QRL rwHMvx+oTEHZmCz/k5K8ryEC2uhAXg+5hnHu85JsP4NfdMqZhi1jRnEmDPlOr73Z6uJk CqQIyk0YYQwthI5DC8EcR1pzHQKEgLBDvOPG4Yp31o7jukFH4pce2rMR3dX24ngsEj05 1c/PQDfdwukfMVvPIQ7to0H/ekndky7xbW2MEyCbYOD3pANuwyWgdcBazDm9p5nembiR FbVeU3NokZ4BNpcymB5RVDnlbcjiScCbmhDOVQxd/HqOkA8clThi+8Xk2Cr5mEnSba0E C4fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rcBjffi4kQszuwFLOMY+Y6F9ZFkZd22+sdJvlsBdEYg=; b=Q+Gly/Gn5/ISf79Yvi5M4FKOjf0QKsqPSuRGrag1eNXRN/m5oh4TEZehrIyOZTqdg7 RkCMADTSnDYtREAljDWQhSyEjGlqXhAjC9lJMN+8KxaoGWyl2lGcbyZOp9e4B0mjSmCe Hg0wKTY06UrCzHqFGjtSCOITC5IrB1fwtiA0JgT1ka2uGxH46kqIxn4puhhpaCyfN/nA 1h19hL5QXcC9FZXYKa4oT+hOQUGO28cOcezsccAf893RXvQ5n5rXBv4af/hZn00rT2Gx Z6uwMI/vw3JIw70/qLUJ5KEtncNnjuojsildHfSjtpJo0HexMO1ht6Rn3+ywxP7oWD61 4Crg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WfGl7ijc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r13si5464796edq.64.2020.05.18.03.13.00; Mon, 18 May 2020 03:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WfGl7ijc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726522AbgERKLN (ORCPT + 99 others); Mon, 18 May 2020 06:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbgERKLN (ORCPT ); Mon, 18 May 2020 06:11:13 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3396FC05BD0A for ; Mon, 18 May 2020 03:11:13 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id n15so1503559pfd.0 for ; Mon, 18 May 2020 03:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rcBjffi4kQszuwFLOMY+Y6F9ZFkZd22+sdJvlsBdEYg=; b=WfGl7ijczvb4fyfsojKm6/aNFhV2eCeaQfVNvf5pSUzoQrH5gSc0teZbBMAQD3ifY6 8Xq7ffvVEKShSI+Y5D6o9r0g4UEiy/7PCijWdtr59qtwztnsYfjZ5zofrHUdFMsVo4Wu gSqS7ohq6M+QiRNe9MEQAsXtzQ33VBfpwAWKjDh13NM7wmhqm6nDAMFd92NTn3M2oxyH vFeI0ylamQfCiWz4KTU1D+PRZrO2D05P7U2Ob+lSoLnkZGe52tqGlEdhsmpwgIjuGZ85 A9JQgrwsUjTvNUgvG25pqMn39fsOoK5hetlUU0Iou4d+M5xy9u68+T0U2Bd2+2LLitfF p2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rcBjffi4kQszuwFLOMY+Y6F9ZFkZd22+sdJvlsBdEYg=; b=T4hcTg7EWGM4/0Xdy004r/yzJh8k8bKM06k6a1WCTWLv0w3fOY4i8qPvmqvCegQa0q gsxkDnKyYOJPlkyR/QjwXIPYgJmLwKJvrdjKT+Sejq6S8QSHYkRsjs2vio85D+LmAH6R 91eUzJyZY6rhgLV0E9hHwAyiS5a30hqvCRBbBS4G+BICmubK3x86OI4wEWjokxB61b+N AoqVaKgzRoiDBLxLR0LbtVICfLE5lt1rVIvBfJ4oGTThqKPjA1ib1omwdfSsUMSDGKZ8 43BbeGp7KQmbYsO0TMf95NSs+MrxULe6CuoP6clagFPJ696pP/Kx3yXG/7CvFIN71Ejs Q6Ww== X-Gm-Message-State: AOAM533GlHZPG2BPEssuoQIFPf5O5zauD9sOzqzO6Unl7KYOZoRqAlQ0 EU1RC36GTxhlVoTi+s1Os0Y16sVklJ4= X-Received: by 2002:a62:79c2:: with SMTP id u185mr1949116pfc.159.1589796672606; Mon, 18 May 2020 03:11:12 -0700 (PDT) Received: from localhost ([122.167.130.103]) by smtp.gmail.com with ESMTPSA id y22sm2305167pfc.132.2020.05.18.03.11.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2020 03:11:11 -0700 (PDT) Date: Mon, 18 May 2020 15:41:09 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Serge Semin , Serge Semin , Thomas Bogendoerfer , "Rafael J. Wysocki" , Ulf Hansson , Matthias Kaehlcke , Alexey Malahov , Paul Burton , Ralf Baechle , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Frederic Weisbecker , Ingo Molnar , Yue Hu , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 20/20] cpufreq: Return zero on success in boost sw setting Message-ID: <20200518101109.4uggngudy4gfmlvo@vireshk-i7> References: <20200306124807.3596F80307C2@mail.baikalelectronics.ru> <20200506174238.15385-1-Sergey.Semin@baikalelectronics.ru> <20200506174238.15385-21-Sergey.Semin@baikalelectronics.ru> <20200516125203.et5gkv6ullkerjyd@mobilestation> <20200518074142.c6kbofpdlxro2pjz@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-05-20, 11:53, Rafael J. Wysocki wrote: > That said if you really only want it to return 0 on success, you may as well > add a ret = 0; statement (with a comment explaining why it is needed) after > the last break in the loop. That can be done as well, but will be a bit less efficient as the loop will execute once for each policy, and so the statement will run multiple times. Though it isn't going to add any significant latency in the code. -- viresh