Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] blkcg: Fix memory leak in blkg_conf_prep()
To:     Markus Elfring <Markus.Elfring@web.de>, <cgroups@vger.kernel.org>,
        <linux-block@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        "Feilong Lin" <linfeilong@huawei.com>,
        Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
        Zhiqiang Liu <liuzhiqiang26@huawei.com>
References: <4c670a6c-98c3-2b14-7438-09199506d92f@web.de>
From:   Wu Bo <wubo40@huawei.com>
Message-ID: <5cfba9c1-675d-d4e8-65bf-746712ae32e5@huawei.com>
Date:   Mon, 18 May 2020 19:34:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <4c670a6c-98c3-2b14-7438-09199506d92f@web.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/5/15 23:08, Markus Elfring wrote:
> …
>> new_blkg = blkg_alloc(pos, q, GFP_KERNEL);
> …
> 
> I suggest to omit the source code quotation from the change description.
> 
> 
>> if calling blkg_lookup_check() failed, at the IS_ERR block,
>> the new_blkg should be free before goto lable fail_unlock
>> in blkg_conf_prep() function.
> 
> How do you think about a wording variant like the following?
> 
>    If a call of the function “blkg_lookup_check” failed,
>    release the previously allocated block group before jumping
>    to the target “fail_unlock” in the implementation of
>    the function “blkg_conf_prep”.
> 

Thanks for your suggestion. omit the source code quotation from the 
description is more friendly. I will modify the description in V2 patch.

Thanks,
Wu Bo

> 
> Would you like to add the tag “Fixes” to the commit message?
> 
> Regards,
> Markus
>