Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Jiri Kosina <jikos@kernel.org>,
        Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     WANG Wenhu <wenhu.wang@vivo.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        wenhu.pku@gmail.com
Subject: Re: [PATCH] powerpc/sysdev: fix compile errors
In-Reply-To: <nycvar.YFH.7.76.2005181232140.25812@cbobk.fhfr.pm>
References: <20200302053801.26027-1-wenhu.wang@vivo.com> <62251ec1-dd42-6522-dcb2-613838cd5504@c-s.fr> <nycvar.YFH.7.76.2005181228480.25812@cbobk.fhfr.pm> <nycvar.YFH.7.76.2005181232140.25812@cbobk.fhfr.pm>
Date:   Mon, 18 May 2020 21:37:33 +1000
Message-ID: <878shpa2yq.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Jiri Kosina <jikos@kernel.org> writes:
> On Mon, 18 May 2020, Jiri Kosina wrote:
>> > > Include linux/io.h into fsl_85xx_cache_sram.c to fix the
>> > > implicit-declaration compile errors when building Cache-Sram.
>> > >=20
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
>> > > =E2=80=98instantiate_cache_sram=E2=80=99:
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit dec=
laration
>> > > of function =E2=80=98ioremap_coherent=E2=80=99; did you mean =E2=80=
=98bitmap_complement=E2=80=99?
>> > > [-Werror=3Dimplicit-function-declaration]
>> > >    cache_sram->base_virt =3D ioremap_coherent(cache_sram->base_phys,
>> > >                            ^~~~~~~~~~~~~~~~
>> > >                            bitmap_complement
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment m=
akes
>> > > pointer from integer without a cast [-Werror=3Dint-conversion]
>> > >    cache_sram->base_virt =3D ioremap_coherent(cache_sram->base_phys,
>> > >                          ^
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit dec=
laration
>> > > of function =E2=80=98iounmap=E2=80=99; did you mean =E2=80=98roundup=
=E2=80=99?
>> > > [-Werror=3Dimplicit-function-declaration]
>> > >    iounmap(cache_sram->base_virt);
>> > >    ^~~~~~~
>> > >    roundup
>> > > cc1: all warnings being treated as errors
>> > >=20
>> > > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
>> > > Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
>> >=20
>> > Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>=20
>> As this doesn't seem to have been picked up for linux-next yet, I am=20
>> picking it up now.
>
> Only now I've noticed that this is actually a dead code o_O as this file=
=20
> can't be built by any combination of config options. So I am dropping the=
=20
> patch again, but why do we keep it in the tree in the first place?

Yeah, sigh.

As Christophe pointed out, it has been dead code for a long time but
there is a series in flight that's trying to make it usable.

cheers