Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 May 2020 17:13:48 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc:     rjw@rjwysocki.net, Souvik.Chakravarty@arm.com,
        Thanu.Rangarajan@arm.com, Sudeep.Holla@arm.com,
        guohanjun@huawei.com, john.garry@huawei.com,
        jonathan.cameron@huawei.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/3] cpufreq: handle the return value of
 '.set_boost()' properly
Message-ID: <20200518114348.z55kpbhgbfxenrhm@vireshk-i7>
References: <1589785808-12138-1-git-send-email-wangxiongfeng2@huawei.com>
 <1589785808-12138-2-git-send-email-wangxiongfeng2@huawei.com>
 <20200518074619.yznopcgqmoq6ds7t@vireshk-i7>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200518074619.yznopcgqmoq6ds7t@vireshk-i7>
User-Agent: NeoMutt/20180716-391-311a52
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 18-05-20, 13:16, Viresh Kumar wrote:
> On 18-05-20, 15:10, Xiongfeng Wang wrote:
> > 'freq_qos_update_request()' called by 'cpufreq_boost_set_sw()' reutrns 1
> > when the effective constraint value of frequency QoS has changed. It's
> > not an error code. So handle the return value 1 of '.set_boost()' in
> > 'cpufreq_boost_trigger_state()' properly.
> > 
> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> > ---
> >  drivers/cpufreq/cpufreq.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 4adac3a..bb6746e 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -2540,7 +2540,10 @@ int cpufreq_boost_trigger_state(int state)
> >  	write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> >  
> >  	ret = cpufreq_driver->set_boost(state);
> > -	if (ret) {
> > +	if (ret == 1) {
> > +		pr_debug("The effective constraint value of frequency QoS has changed.\n");
> > +		return 0;
> > +	} else if (ret) {
> 
> Rafael, IMO it is better to pick patch from Sergey for this as this is
> implementation detail.
> 
> >  		write_lock_irqsave(&cpufreq_driver_lock, flags);
> >  		cpufreq_driver->boost_enabled = !state;
> >  		write_unlock_irqrestore(&cpufreq_driver_lock, flags);

This is already fixed in the PM tree with a different patch Xiongfeng.

-- 
viresh