Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2658193ybk; Mon, 18 May 2020 04:56:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzllh9QLJUlKFwpnxKBV0MDD6KlFuk2rFkR4j10o543IvoFZK9ZTF8oc4AmZElbOe7lAqEE X-Received: by 2002:a50:fd04:: with SMTP id i4mr13570934eds.43.1589803001576; Mon, 18 May 2020 04:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589803001; cv=none; d=google.com; s=arc-20160816; b=Y/LR/8vwQrAERa/EtmVNMsyxga6Djpg31pbyBFUHj5VPbC4Az/dwc8d7kbQ4qNDv/k WMD1Ps0YI0WwV7mzsw3MDoGRp0IuZitVRAqOlPRbrJY2izCy/oERb+aQa3+rWJ9xs2R9 xvlPfpV/YkKwcS7Ko3HhVX2LxdzyNUCMi0QidjAo9FxfbkKK2TX67GSKgTcyC1udAY5I PZDmhUicqwuvqSQfFNBYmPkupJyl9OlprKXiZfHw2Kk05zhP1ubLkiBozAH6I8/kFbfu GeBdC1eE0hlP8dX8Db+xx1EQaV7oNiaOfsmiZrKfORK9sNqnxln+LWVuFHrUuHLc7fCV 2ikQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ULgLBSCxKiPi5BTXccp7hKcvrNgD/F78HWkfFoXWtQc=; b=OcZp3gDd20I+hP3R+F+kgFASOtXIo14EqD3MTYXLsrMt1+4zeri+9N2tz0Mo8qMtRD nVgPboiEiuInWzUQEOOcWdFYs1I4EGQAD+9Vgs8keQYy0c4t2xq/HAMQ8Y+nc9tQbftB DFg9ooJKGT7gnh+rKnU2/kIFkn05FZhtkf3S+z7UN4ca+aOK5Hy3O2X6Brepe1RWBcvj rI36cQP6g00Mks6z169HscnNJkyHmpwN2NLSkgaQxyB7OBp3Rbm67V6wVYokUBy7gkJY ley6zAxIk129xFg1GOtEEyuaCvH4zR97qcare2UyUsZMIof3ZQV6u7U4pbgVfjhJnHlI WPLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 23si6558422edx.48.2020.05.18.04.56.18; Mon, 18 May 2020 04:56:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbgERLw1 (ORCPT + 99 others); Mon, 18 May 2020 07:52:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38270 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726413AbgERLw1 (ORCPT ); Mon, 18 May 2020 07:52:27 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04IBWP7F054515; Mon, 18 May 2020 07:51:08 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 313r0xuesb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2020 07:51:08 -0400 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 04IBWQWj054578; Mon, 18 May 2020 07:51:07 -0400 Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0b-001b2d01.pphosted.com with ESMTP id 313r0xuerc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2020 07:51:07 -0400 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 04IBkXpk030546; Mon, 18 May 2020 11:51:05 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma04fra.de.ibm.com with ESMTP id 3127t5sn29-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 May 2020 11:51:05 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 04IBp3C743712642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 May 2020 11:51:03 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D825952052; Mon, 18 May 2020 11:51:02 +0000 (GMT) Received: from oc3871087118.ibm.com (unknown [9.145.23.117]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id D378B5204E; Mon, 18 May 2020 11:51:01 +0000 (GMT) Date: Mon, 18 May 2020 13:51:00 +0200 From: Alexander Gordeev To: Andy Shevchenko Cc: Linux Kernel Mailing List , linux-s390@vger.kernel.org, Stable , Yury Norov , Andy Shevchenko , Amritha Nambiar , Arnaldo Carvalho de Melo , Chris Wilson , Kees Cook , Matthew Wilcox , Miklos Szeredi , Rasmus Villemoes , Steffen Klassert , "Tobin C . Harding" , Vineet Gupta , Will Deacon , Willem de Bruijn Subject: Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs Message-ID: <20200518115059.GA19150@oc3871087118.ibm.com> References: <1589798090-11136-1-git-send-email-agordeev@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676 definitions=2020-05-18_04:2020-05-15,2020-05-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 cotscore=-2147483648 phishscore=0 mlxlogscore=999 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005180100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 02:33:43PM +0300, Andy Shevchenko wrote: > On Mon, May 18, 2020 at 1:40 PM Alexander Gordeev > wrote: > > > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does > > not take into account order of halfwords on 64-bit big > > endian architectures. > > Thanks for report and the patch! > > Did it work before? Can we have a test case for that that we will see > the failure? The test exists and enabled with CONFIG_TEST_BITMAP. It does not appear ever passed before on 64 BE. It does not fail on 64 LE for me either. Thanks! [...] > -- > With Best Regards, > Andy Shevchenko