Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2725481ybk; Mon, 18 May 2020 06:34:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyX7B+ssfl0WBVLLDlBvoi+Sudzh0ep4NaUWqi6aEmsbRMCA+5r0bLgBU0UFkJcGkfmpNi9 X-Received: by 2002:a50:9317:: with SMTP id m23mr12575617eda.65.1589808860261; Mon, 18 May 2020 06:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589808860; cv=none; d=google.com; s=arc-20160816; b=RTdbpl4Z5XZ+Z7a+FcKxRMPnfRXnmxOUOpQMM0SbXBvgFs5nPbrXmWvcwsYiakZKko eTVlN6sGgST+HGh9X70gtowQ6Z0NDg2Et7L32x0F3Uj+P4dG9rAHoXFKz4uQZywTwGfU oAAlvt+idCMWA1vH8zAFhYKtGVuD3Rxw2GlqTPVtlDJUlwz2bVikqzYHY3xZ1qSy9rwX Imt7AQeAp/RC7lwEpPWy6QupfGcbT9KTtVzVt9VqcnfA0bZxrHVWcBiqdYM9MHnx+Xh1 623ld7r34mXnqZ/bihQkRe0dlACjEbW6bsZ4S+2GgoulyzAfKHvi4XzQHZjswhXWHVw3 sFIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=X6LcSxzpha4BKg5KwOtGehesI/z9O4wscW89NeBKcsg=; b=Mx3zavQ0MLB1DRki26dTLPZLrvb6TUk1nqdTwo4wBoC2ZQ9r2Va0bhBnFBIVoGE3lV 0maPoE0iJPJa+fGMnzNsiE2+L1DPN/G68+qox/IJUjIKGWmyejVyGERC04Q9qyIgKu1m /J9QncT211pwGa7dQzDiHD/7dMgRAt5OWtJRN0M0WvO+UtPyFWpHITm3b5v1KYTPiJ7y N0/PuTfIiw5pclKz57VTbi7q9xmLNVx58s8Ovb8C9EcQLkdCsoBgyUxA1Qkx6fFDtVAm oeGifSa6LoGfit/RxUReZCgdy1z1YZAXJcaB6PGt8oMY+WlvYsU9TBFoKFY9eVvFhghi gAPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si1286407eji.323.2020.05.18.06.33.53; Mon, 18 May 2020 06:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbgERNcN (ORCPT + 99 others); Mon, 18 May 2020 09:32:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:35004 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbgERNcM (ORCPT ); Mon, 18 May 2020 09:32:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 89A9AACCE; Mon, 18 May 2020 13:32:14 +0000 (UTC) Date: Mon, 18 May 2020 15:32:09 +0200 From: Joerg Roedel To: Kai-Heng Feng Cc: iommu@lists.linux-foundation.org, open list Subject: Re: [Regression] "iommu/amd: Relax locking in dma_ops path" makes tg3 ethernet transmit queue timeout Message-ID: <20200518133209.GM8135@suse.de> References: <4E9B03FB-9DA5-4831-B4CE-A0AA645D3F22@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E9B03FB-9DA5-4831-B4CE-A0AA645D3F22@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 05:06:45PM +0800, Kai-Heng Feng wrote: > Particularly, as soon as the spinlock is removed, the issue can be reproduced. > Function domain_flush_complete() doesn't seem to affect the status. > > However, the .map_page callback was removed by be62dbf554c5 > ("iommu/amd: Convert AMD iommu driver to the dma-iommu api"), so > there's no easy revert for this issue. > > This is still reproducible as of today's mainline kernel, v5.7-rc6. Is there any error message from the IOMMU driver?