Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2731892ybk; Mon, 18 May 2020 06:43:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7MfwD7FILOGRbpcg3uZLB9v4+PyZNNE2yPSUK+3TTDQJJccYuESya/mDb3tnAsFXRv3Ym X-Received: by 2002:a05:6402:357:: with SMTP id r23mr13359873edw.230.1589809400102; Mon, 18 May 2020 06:43:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589809400; cv=none; d=google.com; s=arc-20160816; b=b9G1bt/2t2byvw6s2J3RCx4r5KaKBYFTs394oXYIMiEptLlgwLGTKQTcWG7pv9S/hv YaelYHphliOTr7uLnPZwe1NUKCkX1zTU9t2XnfbpOSaF/jCXXeVg0DFq+1g4jbJNfAr6 XYwmuupMgzS26HSk1iyA/8sOf7jhX4LUy0Ym3UKSqkBIqVZzpLxlS4sl1ttldd0ZtAqk XwSfC4bacZ4IQxBTK9xWF2edVbCJm2VTuPp0Xl7XjzOvN2qS6Xo9+ShPFj6degf3mAxT go0kfVVIKW6fFeee6ZYkYST4k8B1ujVyX+Dq/ic96UWfFHPPO7ABNrV9biN2iIGu8u9r sWbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:to:subject:ironport-sdr :ironport-sdr; bh=OoJBfKffoTR1YmDbu1EGBLga7K2DoqJMJar1NRr9pms=; b=WX3PciyqUYzN7RaTyKU4p5PVjXfIqx7GIUi6z2B5LiGKx9kbtgbwGQmwZxqYt4zSnW rYv35Ce8sz3RX8HNe5fBloQ6kZg9uJcls6npJcpP35nSsWz34C4slRijZsON2tQyFFux n8U02xOej6kN4Bm8gorWCtJZC8/Wd/njoxLYq+vlNq080zPNfYTK8FTzyvrbA3bCcpiI +GoQj2kT1VNPgsDVK69bnSrBhqEoRQ1h1EgqgSmCC+IC9tmbbfqiRFl4xMffslz9kTB+ ehXIgutro91RlvJVu+/m7LFglwTPJPgid+FKVTqZ3VJ9SomvbWN79SoDe8MjWzrXXfmc 5mBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si6536923ejj.491.2020.05.18.06.42.56; Mon, 18 May 2020 06:43:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbgERNle (ORCPT + 99 others); Mon, 18 May 2020 09:41:34 -0400 Received: from mga01.intel.com ([192.55.52.88]:63863 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726726AbgERNld (ORCPT ); Mon, 18 May 2020 09:41:33 -0400 IronPort-SDR: zlM5V4zypDNSJVVP21WruDqEPviE8PTu+EvEz79QugPVIkmOlbIPb9AZ0R05US/qZlz4dN/WMx IMC+k+CuJImw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 06:41:32 -0700 IronPort-SDR: UZ/h8zX+CotKn848uPmboz3cCOvLqIzC7Kh0StYsA3DDphhm7Kv2y6GY+HcZIKY2LUwLpC+Gy7 NzZZ+gwGbj0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="267520948" Received: from sksoni-mobl.amr.corp.intel.com (HELO [10.255.1.54]) ([10.255.1.54]) by orsmga006.jf.intel.com with ESMTP; 18 May 2020 06:41:27 -0700 Subject: Re: [PATCH v10 01/26] Documentation/x86: Add CET description To: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang References: <20200429220732.31602-1-yu-cheng.yu@intel.com> <20200429220732.31602-2-yu-cheng.yu@intel.com> <5cc163ff9058d1b27778e5f0a016c88a3b1a1598.camel@intel.com> <44c055342bda4fb4730703f987ae35195d1d0c38.camel@intel.com> <32235ffc-6e6c-fb3d-80c4-a0478e2d0e0f@intel.com> <631f071c-c755-a818-6a97-b333eb1fe21c@intel.com> <0f751be6d25364c25ee4bddc425b61e626dcd942.camel@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <6f2ef0e5-d3bb-2b52-dc81-8228fec4a3f5@intel.com> Date: Mon, 18 May 2020 06:41:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <0f751be6d25364c25ee4bddc425b61e626dcd942.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/15/20 7:53 PM, Yu-cheng Yu wrote: > On Fri, 2020-05-15 at 16:56 -0700, Dave Hansen wrote: >> What's my recourse as an end user? I want to run my app and turn off >> CET for that app. How can I do that? > > GLIBC_TUNABLES=glibc.tune.hwcaps=-SHSTK,-IBT Like I mentioned to H.J., this is something that we need to at least acknowledge the existence of in the changelog and probably even the Documentation/. >>>> I think you're saying that the CET-enabled binary would do >>>> arch_setup_elf_property() when it was first exec()'d. Later, it could >>>> use the new prctl(ARCH_X86_CET_DISABLE) to disable its shadow stack, >>>> then fork() and the child would not be using CET. Right? >>>> >>>> What is ARCH_X86_CET_DISABLE used for, anyway? >>> >>> Both the parent and the child can do ARCH_X86_CET_DISABLE, if CET is >>> not locked. >> >> Could you please describe a real-world example of why >> ARCH_X86_CET_DISABLE exists? What kinds of apps will use it, or *are* >> using it? Why was it created in the first place? > > Currently, ld-linux turns off CET if the binary being loaded does not support > CET. Great! Could this please be immortalized in the documentation for the prctl()? >>>>>> Does this *code* work? Could you please indicate which JITs have been >>>>>> enabled to use the code in this series? How much of the new ABI is in use? >>>>> >>>>> JIT does not necessarily use all of the ABI. The JIT changes mainly fix stack >>>>> frames and insert ENDBRs. I do not work on JIT. What I found is LLVM JIT fixes >>>>> are tested and in the master branch. Sljit fixes are in the release. >>>> >>>> Huh, so who is using the new prctl() ABIs? >>> >>> Any code can use the ABI, but JIT code CET-enabling part mostly do not use these >>> new prctl()'s, except, probably to get CET status. >> >> Which applications specifically are going to use the new prctl()s which >> this series adds? How are they going to use them? >> >> "Any code can use them" is not a specific enough answer. > > We have four arch_ptctl() calls. ARCH_X86_CET_DISABLE and ARCH_X86_CET_LOCK are > used by ld-linux. ARCH_X86_CET_STATUS are used in many places to determine if > CET is on. ARCH_X86_CET_ALLOC_SHSTK is used in ucontext related handling, but > it can be use by any application to switch shadow stacks. Could some of this information be added to the documentation, please? It would also be nice to have some more details about how apps end up using ARCH_X86_CET_STATUS. Why would they care that CET is on?