Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2754551ybk; Mon, 18 May 2020 07:11:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIe27dHbEt6nSimR6ZEIUexoSl1zOpzLYHHNqjkVBEEITv53LEN+za1cCU20LGE/jRRjqX X-Received: by 2002:a50:ccc5:: with SMTP id b5mr13164685edj.340.1589811088151; Mon, 18 May 2020 07:11:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589811088; cv=none; d=google.com; s=arc-20160816; b=LyXJ3gk2U2gowPlbRvgkD28QdqIf1zG9UXI+mIZCTNp6H99Gy9wRNQu/pbchv4vBjX k3v73Hul2s0UYOd7udVVqjUjhLwQmCTDldGgUOnJJo+PzIugnT5vtFpbiw1anlf1v/66 COggpaEDfuuuj9+edNAMm5D7HhvFETLgvHgmosVZT5FliDf2fil7FTNozvwzA0HK7xJF YDhAsUU2bwbuMcaTKQ29hpCs1ZSwuzovRgEjLoZoaf63KBxQttoH33WZ9fplxz2LUKPK rw4O7bSxdzHtB4tr3iKfZeeElqqZZWEv8vhsWrdowPifJqVgYxztlyCq/dgbnpEtiJ1g q2EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=KP1W2Itm/+ybI6CcKF2T7q86qg0QdOvp+lK7UryjN2U=; b=rGYjHZ1qIiMNgcbey3go0JY8596yplcuK/OBYEU0DYZTqCMVPFyLDmOWPSLjlYkd0g tOV3JhywnY6MVbN35Fx9HUMQZEsin15gsNqJcGBjoc5G7voifl1AJZf7stHHdZrnFlun RPnyNCxXX09W/o92HKQr8rOBpNt8hzMzyPH3iDLw4U9TinBZienBXFgspUkwc83DIXyg EDA4oNidam2nh5MG0XAu5D+yBMB0z6JLwyyxzK+Vc25fcyfKkJwR8LyN4IjrofL6BZJ/ icej1INBgskzj/nSRMAuhpapMMw7GifzwYmT8aySeEPcbLlUSzWQCA641ca5GiNxXJyA muVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JNmEf5rw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si5786313edx.529.2020.05.18.07.11.03; Mon, 18 May 2020 07:11:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JNmEf5rw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727840AbgEROJ3 (ORCPT + 99 others); Mon, 18 May 2020 10:09:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726945AbgEROJ2 (ORCPT ); Mon, 18 May 2020 10:09:28 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D1F6C061A0C for ; Mon, 18 May 2020 07:09:27 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id n5so10634114wmd.0 for ; Mon, 18 May 2020 07:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KP1W2Itm/+ybI6CcKF2T7q86qg0QdOvp+lK7UryjN2U=; b=JNmEf5rwJZJTr3vmTU+JXBnKh939INhFXQISR4gZuwZuwNupLRBzf58/B385vN8CHT yAfEk+7buu6f8M6Z72fr0I46EKkUNOnbKCtWZ+F7Arox8Bqaq+sbNbEjR2iBIaQN9yr5 gEieuiOZK80sU81Aw6EV7G5+HB+Yd8A5GGNYnTZ/NZYFAUoVGSKqOsT9++GZV5IDShCi KWr5whkVMdxzwp/VgAlUvpzBSqlKMHsfbLf/Vdx0iJulRNme1RDydeGFKU2yWukycvuC H9KvUAG4zcbPJP3X1O5kf/zXTEcZoJRJeS+9yoKUytzw0Yc++ZRyVy6FuCkHCNFTUSE7 RDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KP1W2Itm/+ybI6CcKF2T7q86qg0QdOvp+lK7UryjN2U=; b=g+4a4S+jQz3E/+SDMN6jfezJ+a73W9cHgi5sBhlaqp0gdwQZHQEDKbUQ8Qk1L9vDMz INyDEVQHqsEM3VKcpXjbIi5vzsREJWjUHdOLIn0UYWencosJ0OV6vI7z28L/jTBtEqWL 9BXeL+IXX5KU/zm00kY4YZ5GADa2c1zZj9Xe/Zsg2eBH8ChReuQyG3KuIHfbZRLx6ZLg ea1jLVDUUX9/myW0BCp2c1yOE2oDRGQidUIiBBVXJAgRGOxriZBCHIv93a8tAr2MvexL WG1Px84xC18W/R10X1ijXQzM8iFtrEjoka2pUddk0iG7sLFUn+WsshPyREAgRqxNfvJx 6z9Q== X-Gm-Message-State: AOAM530qmC5nPwol9IXSGD55vus4ae2IqSgK9PvM9SWRXr8cyhoBOW+D uvGGBybcWE8WOAALpkDd2fHCR0KzrAk= X-Received: by 2002:a05:600c:2dd7:: with SMTP id e23mr19309184wmh.96.1589810965999; Mon, 18 May 2020 07:09:25 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:9e7:3ac5:a930:2cd8? ([2a01:e34:ed2f:f020:9e7:3ac5:a930:2cd8]) by smtp.googlemail.com with ESMTPSA id s11sm16348361wrp.79.2020.05.18.07.09.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 07:09:25 -0700 (PDT) Subject: Re: [PATCH 09/10] timer-riscv: Fix undefined riscv_time_val To: Palmer Dabbelt , wangkefeng.wang@huawei.com, tglx@linutronix.de Cc: Paul Walmsley , aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, hulkci@huawei.com References: From: Daniel Lezcano Message-ID: <66121f9a-48f3-d3a5-7c96-d71397e12aed@linaro.org> Date: Mon, 18 May 2020 16:09:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/05/2020 23:14, Palmer Dabbelt wrote: > On Sun, 10 May 2020 19:20:00 PDT (-0700), wangkefeng.wang@huawei.com wrote: >> ERROR: modpost: "riscv_time_val" [crypto/tcrypt.ko] undefined! >> >> Reported-by: Hulk Robot >> Signed-off-by: Kefeng Wang >> --- >>  drivers/clocksource/timer-riscv.c | 1 + >>  1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clocksource/timer-riscv.c >> b/drivers/clocksource/timer-riscv.c >> index c4f15c4068c0..071b8c144027 100644 >> --- a/drivers/clocksource/timer-riscv.c >> +++ b/drivers/clocksource/timer-riscv.c >> @@ -19,6 +19,7 @@ >> >>  u64 __iomem *riscv_time_cmp; >>  u64 __iomem *riscv_time_val; >> +EXPORT_SYMBOL(riscv_time_val); >> >>  static inline void mmio_set_timer(u64 val) >>  { > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt > > Adding the clocksource maintainers.  Let me know if you want this > through my > tree, I'm assuming you want it through your tree. How can we end up by an export symbol here ?! -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog