Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: EF5Lfdgy74IYwQ86r6wmatB8YvQZgY4mOO2VY8Hpc0r5bZlzckU+h0RJG30/qDXn4CzCiDVp7y
 AqOB7iLARSeg==
IronPort-SDR: u5e5rPM4MNDxyUv86aT/GN85X7sYKIzuJJ9PQTchWQ99t3JEN/+ExEJ5A3dAkHVdka8nRL/+6b
 /9izMuLA2scA==
Subject: Re: [PATCH v5 4/5] perf stat: Save aggr value to first member of
 prev_raw_counts
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
References: <20200514053638.3736-1-yao.jin@linux.intel.com>
 <20200514053638.3736-5-yao.jin@linux.intel.com>
 <20200518124826.GF3726797@krava>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <8ea36c95-3b38-a31e-b05a-41c9ccbada51@linux.intel.com>
Date:   Mon, 18 May 2020 22:44:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200518124826.GF3726797@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/18/2020 8:48 PM, Jiri Olsa wrote:
> On Thu, May 14, 2020 at 01:36:37PM +0800, Jin Yao wrote:
>> To collect the overall statistics for interval mode, we copy the
>> counts from evsel->prev_raw_counts to evsel->counts.
>>
>> For AGGR_GLOBAL mode, because the perf_stat_process_counter creates
>> aggr values from per cpu values, but the per cpu values are 0,
>> so the calculated aggr values will be always 0.
>>
>> This patch uses a trick that saves the previous aggr value to
>> the first member of perf_counts, then aggr calculation in
>> process_counter_values can work correctly for AGGR_GLOBAL.
>>
>> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
>> ---
>>   tools/perf/util/stat.c | 10 ++++++++++
>>   tools/perf/util/stat.h |  1 +
>>   2 files changed, 11 insertions(+)
>>
>> diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
>> index aadc723ce871..fbabdd5b9b62 100644
>> --- a/tools/perf/util/stat.c
>> +++ b/tools/perf/util/stat.c
>> @@ -249,6 +249,16 @@ void perf_evlist__copy_prev_raw_counts(struct evlist *evlist)
>>   		perf_evsel__copy_prev_raw_counts(evsel);
>>   }
>>   
> 
> much better, please put some comments in here explaning wha
> is this for, because it's not obvious ;-)
> 
> thanks,
> jirka
> 

Thanks, I will put some comments in v6.

Thanks
Jin Yao

>> +void perf_evlist__save_aggr_prev_raw_counts(struct evlist *evlist)
>> +{
>> +	struct evsel *evsel;
>> +
>> +	evlist__for_each_entry(evlist, evsel) {
>> +		*perf_counts(evsel->prev_raw_counts, 0, 0) =
>> +			evsel->prev_raw_counts->aggr;
>> +	}
>> +}
>> +
>>   static void zero_per_pkg(struct evsel *counter)
>>   {
>>   	if (counter->per_pkg_mask)
>> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
>> index 62cf72c71869..18ead55756cc 100644
>> --- a/tools/perf/util/stat.h
>> +++ b/tools/perf/util/stat.h
>> @@ -199,6 +199,7 @@ void perf_evlist__free_stats(struct evlist *evlist);
>>   void perf_evlist__reset_stats(struct evlist *evlist);
>>   void perf_evlist__reset_prev_raw_counts(struct evlist *evlist);
>>   void perf_evlist__copy_prev_raw_counts(struct evlist *evlist);
>> +void perf_evlist__save_aggr_prev_raw_counts(struct evlist *evlist);
>>   
>>   int perf_stat_process_counter(struct perf_stat_config *config,
>>   			      struct evsel *counter);
>> -- 
>> 2.17.1
>>
>