Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 18 May 2020 16:50:39 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     tanhuazhong <tanhuazhong@huawei.com>
Cc:     f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com, kuba@kernel.org,
        Yufeng Mo <moyufeng@huawei.com>,
        Jian Shen <shenjian15@huawei.com>
Subject: Re: [PATCH net-next] net: phy: realtek: add loopback support for
 RTL8211F
Message-ID: <20200518145039.GA624248@lunn.ch>
References: <1589358344-14009-1-git-send-email-tanhuazhong@huawei.com>
 <20200513131226.GA499265@lunn.ch>
 <cb82153d-e14e-8e97-b3b8-210135fbdee6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cb82153d-e14e-8e97-b3b8-210135fbdee6@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Hi, Andrew.
> 
> There are two type of phys we are using, rtl8211f and "Marvell 88E1512".
> "Marvell 88E1512" has already supported loopback
> (f0f9b4ed2338 ("net: phy: Add phy loopback support in net phy framework")).

> So now we adds loopback support to the rtl8211f.
> From the data sheet other phys should support this loopback as well, but
> we have no way to verify it. What's your suggestion?

So you checked the datasheets for the RTL8201CP, RTL8201F, RTL8208,
RTL8211B, RTL8211DN, etc?

For all those you have datasheets for, please also add loopback
support. I'm just trying to avoid one PHY from twelve in that driver
having loopback support, when they all probably can.

       Andrew