Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2843249ybk; Mon, 18 May 2020 09:13:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPoQD++7dGosRDWoKk5uApnImjdFGsL/Ow7MYXRsgpM0/EmZ+MOZmLULwW8qu5TiT91gqX X-Received: by 2002:a17:906:3944:: with SMTP id g4mr16098219eje.55.1589818418550; Mon, 18 May 2020 09:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589818418; cv=none; d=google.com; s=arc-20160816; b=zp3o31TTwMxYOYDViVyuJvVezGSwKooRXP0wccO/07QpeYdb8LJYBVSzOECtg/8n/1 3A0oNnmOh5oacUx5FVjEcYsc7rUmGYlEFd375k6eVIL0b8HTqgDEVnAprE2fPEpeAQHY i5g/+JpKNHyEAxtUXq5JYHYYRAzfBtPLbpuYcO44u5brEuRHVw5eGeBGz2Xgr4sTgWZf UOR2XvoSsF+Vo15HLcRmiLzeYsRso1VGH5M6+sw7ehUDeT5IvkjhJxFL0F9/9pBs/7dV w5JBTgr3RxQNSauFn5ojN5knC4kTHOKx5/xt5nFz01RmvX6p8XZVdFismMgBzsIzlu7w z2kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=UvPpDrJRTISjRmaitgDIto8RJyndLCc2sSj57LCcK5s=; b=qrsRB9ZnPUiFwE1DHmT9WdP8D00BZT2/O0V1sq0uPMsUQd8jDTs5X8zbZD+5DtyZN5 80YsC9rNRpzWgG6YoucLDOA6X31Bznj6qjPLLVELUzqN/t2sslSihhjHL6PtF2T6SbL6 YLO8TCuhLpAdre+IsLAC60DbXNIrFhIpVVIHEAmTBc2zRxq4ZvYa81aPKTISo2J1ZyNj d38jv009lGZHmZNesAr8ld298iVLGHwtD/+2JhXIGpsly19AalNwl9JRvQ9g6iA/ZnKh 8k5fkc71AfcgB6SaBVdTar2n+HcB45reZVUwZ3/fwn+Tp0s/3P8uB9reBw4BW8BLnSI8 3Wsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kJriiaT8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si6572009eja.51.2020.05.18.09.13.13; Mon, 18 May 2020 09:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kJriiaT8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbgERQIZ (ORCPT + 99 others); Mon, 18 May 2020 12:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727903AbgERQIZ (ORCPT ); Mon, 18 May 2020 12:08:25 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 618D4C05BD09 for ; Mon, 18 May 2020 09:08:25 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id 5so36102pjd.0 for ; Mon, 18 May 2020 09:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UvPpDrJRTISjRmaitgDIto8RJyndLCc2sSj57LCcK5s=; b=kJriiaT8bwsbMU+17BfUzGJkZ5x7ACjzaUbUglQ0rEiAY4dvdhLlmrkZ7+euuzmk+j 4qsmp7fzIrkvDRISd7JmCZvLc9Gyv51lm8tg3i2ltRzdUwDpEN/LXoB8wd02AqeRBr/B lzfu/wW2z8yfRnFdZmtyJ/Yx5/0hqU2LYRXLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UvPpDrJRTISjRmaitgDIto8RJyndLCc2sSj57LCcK5s=; b=RWrWgu9WHoX9a1PKqk1cBOmSXDadeC+mRkKvhaPl5/CfBFxgrHFUKDsFd+pUlcO9oE qJBn5/oHC0hYhBdpvarkprc/w1KCgnWvQa0ICj/QBRTKo1McaNxx1fp6OpzvWYXdNIIA LO1VebjSw0ROCyV3iMtx2YKUafGZ5sCnuZWCCDfcI89MSZ8cMVlAsmqSMPRZYqcK8pQF bqX2y6E75c27kbGJRdgAiJrshYjTJ8Se21ZK4dP3dQM3iPCHT0MWp9eI5fFNl1ZKzvaR qLvQPSnyS4WQOhOUPG6MUqzFStyHNnAAiZLIo+dKOnqrCqIOxdThDhuK8WRSu4nW/R4G WKTw== X-Gm-Message-State: AOAM532nwyhFG+4ui8wzM+3W8EA7JxC8LSE5U0JXHwh68wLavZBAIICK 8EzVhWOZZNbdCsDl5olHstfGEQ== X-Received: by 2002:a17:902:8c8f:: with SMTP id t15mr16690559plo.183.1589818104936; Mon, 18 May 2020 09:08:24 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h4sm8225907pfo.3.2020.05.18.09.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 09:08:24 -0700 (PDT) Date: Mon, 18 May 2020 09:08:22 -0700 From: Kees Cook To: Stephen Kitt Cc: Luis Chamberlain , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sysctl: const-ify ngroups_max Message-ID: <202005180908.C016C44D2@keescook> References: <20200518155727.10514-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518155727.10514-1-steve@sk2.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make > it const, in the same way as cap_last_cap. > > Signed-off-by: Stephen Kitt Reviewed-by: Kees Cook -- Kees Cook