Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JLIKhrEF337eTps4szGdoq643geK3z6RP8ZDnqZjlegwUPBcARIZJKq9yS5vwzDuQzGjfo2y8F
 oj6K4dNwmWGA==
IronPort-SDR: GuRlUgewN1BJf4G2FSzoLvih3E3Ux4CmiLj2lgnXndxIo/H9owYp0NlWzjTfbPg7S4yXnnk0OM
 mT3LvxMNmoUw==
Date:   Mon, 18 May 2020 20:16:46 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Maarten Brock <m.brock@vanmierlo.com>
Cc:     Lukas Wunner <lukas@wunner.de>, Heiko Stuebner <heiko@sntech.de>,
        gregkh@linuxfoundation.org, jslaby@suse.com,
        matwey.kornilov@gmail.com, giulio.benetti@micronovasrl.com,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        christoph.muellner@theobroma-systems.com,
        Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
        linux-serial-owner@vger.kernel.org
Subject: Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable
 GPIO
Message-ID: <20200518171646.GO1634618@smile.fi.intel.com>
References: <20200517215610.2131618-1-heiko@sntech.de>
 <20200517215610.2131618-4-heiko@sntech.de>
 <20200518151241.GG1634618@smile.fi.intel.com>
 <20200518152247.slenjeiiplps7mcd@wunner.de>
 <33547f6a596df2ca2ee8e647111e5fa1@vanmierlo.com>
 <20200518163522.GK1634618@smile.fi.intel.com>
 <f7d408a0ca747086c01999fc0db905da@vanmierlo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f7d408a0ca747086c01999fc0db905da@vanmierlo.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 18, 2020 at 07:05:11PM +0200, Maarten Brock wrote:
> On 2020-05-18 18:35, Andy Shevchenko wrote:
> > On Mon, May 18, 2020 at 06:13:16PM +0200, Maarten Brock wrote:
> > > On 2020-05-18 17:22, Lukas Wunner wrote:
> > > > On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote:
> > > > > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote:

...

> > > But "High" on a gpio would disable the receiver when connected to !RE.
> > 
> > No, that's exactly the point of the terminology (asserted means active
> > whatever
> > polarity it is). You need to define active-low in GPIO description.
> 
> Is there anything wrong with defining GPIOD_OUT_ACTIVE or GPIOD_OUT_ASSERTED
> for this very purpose? May I suggest to deprecate GPIOD_OUT_HIGH and replace
> it?

Please, ask GPIO maintainers, I'm not one.

-- 
With Best Regards,
Andy Shevchenko