Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2906160ybk; Mon, 18 May 2020 10:48:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzD+I6nwC65SZqf5ESxP27v0vqEElepmA6T9KBJlcCSGUXDktXd34h0Y4VElJsKd6PeqzXo X-Received: by 2002:a17:906:a857:: with SMTP id dx23mr16532791ejb.52.1589824088402; Mon, 18 May 2020 10:48:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589824088; cv=none; d=google.com; s=arc-20160816; b=AJ2qpr9F9/avpnYIGg766Y8VTk+QM0tiCqyrxOQ+Kq6mgXAWLTOC8MuXyDOFrKqdX6 dw82GUBDxOEP0LdP39TIIiPYeRbmWlI3Y5747E2Cv4GGHmAN5WN4dlJPMDYTF094TWt/ jImwJI3RkG8UXNX1d9sZeRVO3uAAVls5rjckIupjxE7o6G6ry2e/mcw3B8K+1HR13bHT 5IDodr17lBXGQOpIzO63dwfsefeMEaVXefn7Mx790LRfE9wpw341DOUfxPxZEPE8fH5q zhXNVerULq+Tsks+vPrv6aCUDh5E3emAxU4mn4JTIbtU3/ztxEthVFRsatzSqaBt3smB jE5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rRLTbIH8xICOrZKOA09Zqm9MZXYJ7vEkkyU0o65TOuo=; b=Ej18usctLTEWRpVr3ZJtDW3EMuYpkAO35Wv6dGT65PDRyoqWKAZPZetqEq585jJnEZ 8N5elXD37keFjvzMhorN0chsb7CitpIvokvlVlXbYwYEeJApNZemuR65RtQ25JjwXsbl iTttFdfrgAWKk9trxskZ0UwyPe+oeY6FDfSFqqmcgRb/hS5qZhtRfYECRUAsxLIPtVGM 0gbsv8nHC7lQ1H+JtvH8Q6escDLtvirBliqU7aKw1hlhcvTmkttvOjUZdeQSLBrL/MZ/ SH+wes/cmHCAQukgxAwOVIQQn6USdaN6wHyp26C8T052FPCJiv8LAUpDoYYKVodPOpsS DOMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RitQpEmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s27si7026691ejf.2.2020.05.18.10.47.45; Mon, 18 May 2020 10:48:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RitQpEmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729073AbgERRpP (ORCPT + 99 others); Mon, 18 May 2020 13:45:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:43926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729829AbgERRpN (ORCPT ); Mon, 18 May 2020 13:45:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75B4B207C4; Mon, 18 May 2020 17:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823912; bh=RGT0VjGe9TRQuJHjMcP/kiurgPyuxbygJwlZVLInTgw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RitQpEmRdA6Hjs6OAf2UcpktsdHqCdyW5nrRDRUJ7EV67d6pzG4STChfVZOQq7ZBZ u4QQMiMflB5q7mEN61B6Rq57CKVM7y2EWjXiOEvvRZIOcWwq22tnnhCU8im2O64yWk irkVM30/pVakzX9cWNwRAsL9dKHEe0hNZmGew/HI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kai-Heng Feng , Takashi Iwai Subject: [PATCH 4.9 86/90] Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Date: Mon, 18 May 2020 19:37:04 +0200 Message-Id: <20200518173508.600506560@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173450.930655662@linuxfoundation.org> References: <20200518173450.930655662@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kai-Heng Feng commit f41224efcf8aafe80ea47ac870c5e32f3209ffc8 upstream. This reverts commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757. Enable power save node breaks some systems with ACL225. Revert the patch and use a platform specific quirk for the original issue isntead. Fixes: 3b36b13d5e69 ("ALSA: hda/realtek: Fix pop noise on ALC225") BugLink: https://bugs.launchpad.net/bugs/1875916 Signed-off-by: Kai-Heng Feng Link: https://lore.kernel.org/r/20200503152449.22761-1-kai.heng.feng@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 2 -- 1 file changed, 2 deletions(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4212,8 +4212,6 @@ static void alc_determine_headset_type(s is_ctia = (val & 0x1c02) == 0x1c02; break; case 0x10ec0225: - codec->power_save_node = 1; - /* fall through */ case 0x10ec0295: case 0x10ec0299: alc_process_coef_fw(codec, coef0225);