Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2935551ybk; Mon, 18 May 2020 11:30:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOhYbMj2Ao4c7yTnK88BeH0LSdbXY6DGqc3TKEEufb+sbpRho4kOkYhtyCbteVdM29GDaa X-Received: by 2002:a17:906:57d6:: with SMTP id u22mr15645134ejr.49.1589826626071; Mon, 18 May 2020 11:30:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589826626; cv=none; d=google.com; s=arc-20160816; b=iKE/+FL1ORPJcBZxDWBsz4NCGHvwVDEy3FMOfRbENhmEODpDbW2+aqgEf6II9bLF0A KlK8IRnSlTbW0Jv1huYQg1u2H5sY44PUm3pA9/FsXS42/3oZInSTeyP4V5H3X73kZKp2 FZDBKQ/rCbDVOElBrdXwUYNyU5qWUhk4TSWqE72PZ8qDSkf5aabFmGm3GmgLZBJdxOVI lmbN0wsOrg0zmiVt7N6a70+Ruug0PNb3puGd5mOTqgc26ncjCUiWvJ7N8sqWzDvDkw8z jopJHwn3iNreRPOvcKP7Houv+UwOMUwrR5aBAHYbC5nL/OZ9sMJG7rI6Wm8n9d3Ly4Lx 4RQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Zz0ZLPZTeW3S3aMOEkck5R8g5VtjwC3/TI8eQ2OIbWQ=; b=s9vBZ/07tFmZ+VqgT+w0rON3Xw0M42q5MNyS2QTYUmAradLfZwwJO+ZycpMs6Rw4F6 h9sLt4iDuCZsP8AOPSUzAUV5x6rJ8oFO8ElYIzUv+JygD5pxCt93CV+A4cebq/mKKW0c ZkJGic/vI9Dxf5nUdKH35T+RyoQ9rx2Fj+BO6DdJ8U8g7sNGODw05xPuSBHJb+vNu9uy cdlDTksX9K+Ph+Cc1bAdhc5XE9zKY5ZoM6JrzxEFpuWhpmdpXLdiGHZL2/3angAqqpyn Uq0/B8dTClEhAMcvgbCS2+BFCN1kEhv4bVSCiHfJt9tkzv5qkwkX/aTiRn+1MJ26o2Iw afKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="a/8xBhhh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr5si6549206ejb.509.2020.05.18.11.30.02; Mon, 18 May 2020 11:30:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="a/8xBhhh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387964AbgERS17 (ORCPT + 99 others); Mon, 18 May 2020 14:27:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:41042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729576AbgERRn0 (ORCPT ); Mon, 18 May 2020 13:43:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4D7320657; Mon, 18 May 2020 17:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823806; bh=WdLbPh1jVdQM0eslIz62960jia9I6v4aRFvUL1SGIvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a/8xBhhhxTE0JOz41GxIEzYHvZGXsEMgOkj6rgFlNsz/AdCS2BZHNbvweZKNvJ9eu tq7240sr1uBmzp7e0H94ToHCgyibz5JN0Y6SOibsDePw4LyQ2c0PqAxGRgLgRBEyXV T1suOf5TV0KIo0ovmBFAbqVF+UM1IC8O1aK7W0DI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 43/90] net: moxa: Fix a potential double free_irq() Date: Mon, 18 May 2020 19:36:21 +0200 Message-Id: <20200518173500.040306716@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173450.930655662@linuxfoundation.org> References: <20200518173450.930655662@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ] Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: Christophe JAILLET Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/moxa/moxart_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index 0622fd03941b8..6fe61d9343cb8 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -571,7 +571,7 @@ static int moxart_remove(struct platform_device *pdev) struct net_device *ndev = platform_get_drvdata(pdev); unregister_netdev(ndev); - free_irq(ndev->irq, ndev); + devm_free_irq(&pdev->dev, ndev->irq, ndev); moxart_mac_free_memory(ndev); free_netdev(ndev); -- 2.20.1