Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbWCNXrQ (ORCPT ); Tue, 14 Mar 2006 18:47:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751631AbWCNXrQ (ORCPT ); Tue, 14 Mar 2006 18:47:16 -0500 Received: from dspnet.fr.eu.org ([213.186.44.138]:43534 "EHLO dspnet.fr.eu.org") by vger.kernel.org with ESMTP id S1751312AbWCNXrQ (ORCPT ); Tue, 14 Mar 2006 18:47:16 -0500 Date: Wed, 15 Mar 2006 00:47:15 +0100 From: Olivier Galibert To: Alan Cox Cc: Marcel Holtmann , "Hack inc." , maxk@qualcomm.com, bluez-devel@lists.sourceforge.net Subject: Re: [PATCH] Fix SCO on Broadcom Bluetooth adapters Message-ID: <20060314234714.GA49778@dspnet.fr.eu.org> Mail-Followup-To: Olivier Galibert , Alan Cox , Marcel Holtmann , "Hack inc." , maxk@qualcomm.com, bluez-devel@lists.sourceforge.net References: <20060314111248.GA75477@dspnet.fr.eu.org> <1142344144.4448.3.camel@aeonflux.holtmann.net> <20060314140828.GA87175@dspnet.fr.eu.org> <1142375276.3623.25.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1142375276.3623.25.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 18 On Tue, Mar 14, 2006 at 10:27:56PM +0000, Alan Cox wrote: > Just add a wildcard quirk so your fixup is called for every single > device and then does the check. Keeps the fix out of the core and > clearly documented while keeping the list short. Errr, ok, I'm all for doing that but I'm not sure what "that" means. You want the test/fix to be put in a function somewhere to be defined and hci_event to call it where I put the if initially? OG. PS: It's only 51 after all. For now, that is, since we know there will be new ones with the same problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/