Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbWCOAc2 (ORCPT ); Tue, 14 Mar 2006 19:32:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752092AbWCOAc2 (ORCPT ); Tue, 14 Mar 2006 19:32:28 -0500 Received: from CyborgDefenseSystems.Corporatebeast.com ([64.62.148.172]:33811 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1751144AbWCOAc1 (ORCPT ); Tue, 14 Mar 2006 19:32:27 -0500 Date: Wed, 15 Mar 2006 11:32:12 +1100 To: David McCullough Cc: Valdis.Kletnieks@vt.edu, Adrian Bunk , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] crypto/aes.c: array overrun Message-ID: <20060315003212.GA20843@gondor.apana.org.au> References: <20060311010339.GF21864@stusta.de> <20060311024116.GA21856@gondor.apana.org.au> <200603142025.k2EKP8Z4010175@turing-police.cc.vt.edu> <20060314225448.GA27285@beast> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060314225448.GA27285@beast> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 25 On Wed, Mar 15, 2006 at 08:54:48AM +1000, David McCullough wrote: > > struct aes_ctx { > int key_length; > - u32 E[60]; > - u32 D[60]; > + u32 _KEYS[120]; > }; Looks good. Thanks for this David. Could you please change the name from _KEYS to buf and patch the x86-64 version as well? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/