Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1487563pjr;
        Mon, 18 May 2020 14:27:07 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx307sl4DLMwzpXW5OXwD4mDaqXBa32wATxj2WQV9K9nz039qwSLrgsDGV333IpzbUuNdGD
X-Received: by 2002:a50:ed16:: with SMTP id j22mr9340451eds.300.1589837227013;
        Mon, 18 May 2020 14:27:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1589837227; cv=none;
        d=google.com; s=arc-20160816;
        b=QuuUVa+QZBkHk7KhRN+mr6svW0u1ZdwRbht/n6+om0Ty646fOLmZa03K0sQkSBnksj
         tThY41Jk4e+TRZqUYn+qL8aSB4BUJ5bab1td1duGPrY3yo/F1LinGnZpbZnEBwQuaWrR
         OmVXM4YYShQYSWRzcrWXSzyeP4dy96TLpFPKmXJINUa5UVlOZE/hbf9LFuF6q+DvSr0r
         UaqNI2Ch2tOhQMUlSt+uTvr3NoCEQ2yVmvHDJPzg4y+DNDHBAXPAFTraJK/P2TaTMCLS
         EKWfCyCDhwK6CE54qB57O80QeOIUdUqc8riOaRUc6+SCagqoylrB1NFyIoCRP1Nf8+0r
         dLTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=E85nFVa8mu0vGn7khXC49N7FJQ3xbA85drUoVklhxno=;
        b=aBSHTEEgC5lQqICvt7rwwKymc1xnAFaPHrOkt7JfBkLnXhi5zzd5zyfhEQvktqnNVC
         cYBwpwzYwrDIr6ZdmVx5fHox4c9DEcSsRJOwcSEJRtwEFW0UB+nEz3kGrFalc7LAThQZ
         f+5MDtdB3QOmt2krg3/lg3lPZVqVU2LZ8HRGtOsMz2SlC3W0nKvslcRLQgfLn5o4n1wd
         Bna6DzuXcuMj/F18T4Xz3WNO4UkyXOmqzrNvcOuGmeKXFiQLJmhWvJ7Rdg6BmBRVUvRS
         e6SvdffCiPi5P2SgqQVpq/VOXJ1x+YJ3WeGhaSr/RIvjtzJcyPoN/VN1X0rAq++YtYVq
         vt+Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=O8T8RwxS;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id q25si6999995ejb.283.2020.05.18.14.26.42;
        Mon, 18 May 2020 14:27:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=O8T8RwxS;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727940AbgERVWj (ORCPT <rfc822;gasparwang.pro@gmail.com>
        + 99 others); Mon, 18 May 2020 17:22:39 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:14641 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726367AbgERVWi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 May 2020 17:22:38 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5ec2fc500000>; Mon, 18 May 2020 14:21:20 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 18 May 2020 14:22:38 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 18 May 2020 14:22:38 -0700
Received: from [10.2.55.90] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 18 May
 2020 21:22:38 +0000
Subject: Re: [RFC] mm/gup.c: Use gup_flags as parameter instead of passing
 write flag
To:     Souptick Joarder <jrdr.linux@gmail.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <1589831903-27800-1-git-send-email-jrdr.linux@gmail.com>
 <20200518201737.GV16070@bombadil.infradead.org>
 <CAFqt6zbcn5kEbtY1fod4yy_PETKX8zVM2NjsY0HHyOixiu2q4w@mail.gmail.com>
 <975cc333-e9f4-29e4-db0e-00ea8b8a7c25@nvidia.com>
 <CAFqt6zZoFBkvkZKOc9mbGVO6_Gst+0k=wpjmXYSKvFru=HgczA@mail.gmail.com>
X-Nvconfidentiality: public
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <4effb531-844e-0755-249f-ba5dea7bf490@nvidia.com>
Date:   Mon, 18 May 2020 14:22:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <CAFqt6zZoFBkvkZKOc9mbGVO6_Gst+0k=wpjmXYSKvFru=HgczA@mail.gmail.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1589836880; bh=E85nFVa8mu0vGn7khXC49N7FJQ3xbA85drUoVklhxno=;
        h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=O8T8RwxSkH+IdRc0E8xXcXXZ3GbbJAx3B/6OP3dwhbwhfvn/jTthg5lb1R35np2cG
         LGGqn2NlgENnn/OyzffzE8mGx729KDQdrdrppRNWh1Of4M/E0yADc24fZ+DWdQcxFj
         ls6LEGLSfOHJQEn+16OxxVZHvDM/AReVcobs80e3ORmIQprOzi74LuU1AX1EFJ5Ob3
         V43mi9iUqr+7FaM/ywAiL+5Gpg/Pu/YqQlHyA7uftO/plG0cXTI8bYXds7LDeflxXV
         WU4vUC223YEbtuPm6DaXJEb1i/dyQiE3yEQtjkSRDrFqdnqGvOw5dTYHLGyaHqQVWU
         yH99yp/2kRGTw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020-05-18 14:06, Souptick Joarder wrote:
...
>> So in other words, if you do go out and change all the call sites (there only
>> seem to be about 7, outside of gup.c, actually), that's going to conflict
>> a little bit with what I'm doing here.
>>
>> So, how would you like proceed? If you want to do the full conversion
>> (which really should include the call sites), it would be easier for me
>> if you based it on my upcoming small patchset, which I expect to post
>> shortly (later today).
> 
> Sure, I will wait for your patchset :)
> 
> As there are only 7 callers of the __get_user_pages_fast(), I prefer to do
> full conversion in a single commit. But if it is not preferred way, I would go
> as per feedback.
> 

Thanks, I appreciate it! And yes, you'll want to do the "write" to "gup_flags"
conversion in a single patch, definitely.


thanks,
-- 
John Hubbard
NVIDIA